Patchwork lua: ensure that host-lua does not depend on host-readline and host-ncurses

login
register
mail settings
Submitter Thomas Petazzoni
Date July 20, 2012, 12:42 p.m.
Message ID <1342788156-17040-1-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/172242/
State Accepted
Headers show

Comments

Thomas Petazzoni - July 20, 2012, 12:42 p.m.
Commit ad6af5819f88bac9ca7f50e565c4fc68d3e408cc removed the
HOST_LUA_DEPENDENCIES assignement to the empty variable, so from that
commit, the dependencies of host-lua are automatically computed from
the dependencies of lua. Since lua can depend on readline and ncurses,
it means that host-lua can depend on host-readline and host-ncurses,
and the host-readline package does not exist in Buildroot. Since there
is no reason to build host-lua with readline/ncurses support, just
re-add the HOST_LUA_DEPENDENCIES variable.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Francois Perrad <fperrad@gmail.com>
---
 package/lua/lua.mk |    3 +++
 1 file changed, 3 insertions(+)
Thomas Petazzoni - July 20, 2012, 6:06 p.m.
Le Fri, 20 Jul 2012 14:42:36 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a écrit :

> Commit ad6af5819f88bac9ca7f50e565c4fc68d3e408cc removed the
> HOST_LUA_DEPENDENCIES assignement to the empty variable, so from that
> commit, the dependencies of host-lua are automatically computed from
> the dependencies of lua. Since lua can depend on readline and ncurses,
> it means that host-lua can depend on host-readline and host-ncurses,
> and the host-readline package does not exist in Buildroot. Since there
> is no reason to build host-lua with readline/ncurses support, just
> re-add the HOST_LUA_DEPENDENCIES variable.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Francois Perrad <fperrad@gmail.com>

Applied, as well as two other fixes to make lua build with gcc 4.6, and
to make host-lua install properly when it is the first host package to
be built.

Thomas

Patch

diff --git a/package/lua/lua.mk b/package/lua/lua.mk
index 8f71fc2..074b9ad 100644
--- a/package/lua/lua.mk
+++ b/package/lua/lua.mk
@@ -23,6 +23,9 @@  else
 	LUA_CFLAGS += -DLUA_USE_POSIX -DLUA_USE_DLOPEN
 endif
 
+# We never want to have host-readline and host-ncurses as dependencies
+# of host-lua.
+HOST_LUA_DEPENDENCIES =
 HOST_LUA_CFLAGS = -Wall -fPIC -DLUA_USE_DLOPEN -DLUA_USE_POSIX
 HOST_LUA_MYLIBS = -ldl