Patchwork audio: Make pcspk card selectable again

login
register
mail settings
Submitter Jan Kiszka
Date July 20, 2012, 7:17 a.m.
Message ID <50090601.40800@web.de>
Download mbox | patch
Permalink /patch/172147/
State New
Headers show

Comments

Jan Kiszka - July 20, 2012, 7:17 a.m.
From: Jan Kiszka <jan.kiszka@siemens.com>

Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per
target. Therefore, statically built soundhw array in arch_init.c stopped
including this card.

Work around this by re-adding this define to config-target.mak.
Long-term, a dynamic creation of this soundhw list will be necessary.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 configure |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Jan Kiszka - Aug. 14, 2012, 11:30 a.m.
On 2012-07-20 09:17, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per
> target. Therefore, statically built soundhw array in arch_init.c stopped
> including this card.
> 
> Work around this by re-adding this define to config-target.mak.
> Long-term, a dynamic creation of this soundhw list will be necessary.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  configure |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/configure b/configure
> index 106209a..77b5096 100755
> --- a/configure
> +++ b/configure
> @@ -3818,6 +3818,11 @@ if test "$target_bsd_user" = "yes" ; then
>    echo "CONFIG_BSD_USER=y" >> $config_target_mak
>  fi
>  
> +# the static way of configuring available audio cards requires this workaround
> +if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
> +  echo "CONFIG_PCSPK=y" >> $config_target_mak
> +fi
> +
>  # generate QEMU_CFLAGS/LDFLAGS for targets
>  
>  cflags=""
> 

Ping.

Sorry in case this arrives twice but the first ping didn't show up on
the list for me.

Jan

Patch

diff --git a/configure b/configure
index 106209a..77b5096 100755
--- a/configure
+++ b/configure
@@ -3818,6 +3818,11 @@  if test "$target_bsd_user" = "yes" ; then
   echo "CONFIG_BSD_USER=y" >> $config_target_mak
 fi
 
+# the static way of configuring available audio cards requires this workaround
+if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
+  echo "CONFIG_PCSPK=y" >> $config_target_mak
+fi
+
 # generate QEMU_CFLAGS/LDFLAGS for targets
 
 cflags=""