Patchwork [U-Boot] arm: rmobile: kzm9g: Fix CONFIG_BAUDRATE setting

login
register
mail settings
Submitter Tetsuyuki Kobayashi
Date July 20, 2012, 2:16 a.m.
Message ID <1342750568-6356-1-git-send-email-koba@kmckk.co.jp>
Download mbox | patch
Permalink /patch/172114/
State Accepted
Delegated to: Albert ARIBAUD
Headers show

Comments

Tetsuyuki Kobayashi - July 20, 2012, 2:16 a.m.
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>

The value of CONFIG_BAUDRATE is treated as string and put as initial value of environment variable. If it begin with '(', it is wrongly parsed to 0 in number. So I removed '(' and ')'.

Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Hi, Iwamatsu-san

This is a kind of regression. The initial value of environment variable of barud rate is wrong. When you flash U-Boot to a new board, serial console doesn't work because board rate is set to 0. If you save environment variables in old version U-Boot, you don't aware this problem.


 include/configs/kzm9g.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Nobuhiro Iwamatsu - July 24, 2012, 1:37 a.m.
Hi,

Applied to rmobile branch.

Best regards,
  Nobuhiro

2012/7/20 Tetsuyuki Kobayshi <koba@kmckk.co.jp>:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> The value of CONFIG_BAUDRATE is treated as string and put as initial value of environment variable. If it begin with '(', it is wrongly parsed to 0 in number. So I removed '(' and ')'.
>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
> Hi, Iwamatsu-san
>
> This is a kind of regression. The initial value of environment variable of barud rate is wrong. When you flash U-Boot to a new board, serial console doesn't work because board rate is set to 0. If you save environment variables in old version U-Boot, you don't aware this problem.
>
>
>  include/configs/kzm9g.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
> index bd157d9..14f088f 100644
> --- a/include/configs/kzm9g.h
> +++ b/include/configs/kzm9g.h
> @@ -46,7 +46,7 @@
>  #define CONFIG_CMD_FAT
>  #define CONFIG_CMD_BOOTZ
>
> -#define CONFIG_BAUDRATE                (115200)
> +#define CONFIG_BAUDRATE                115200
>  #define CONFIG_BOOTARGS                "root=/dev/null console=ttySC4,115200"
>  #define CONFIG_INTEGRATOR
>  #define CONFIG_ARCH_CINTEGRATOR
> --
> 1.7.9.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
index bd157d9..14f088f 100644
--- a/include/configs/kzm9g.h
+++ b/include/configs/kzm9g.h
@@ -46,7 +46,7 @@ 
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_BOOTZ
 
-#define CONFIG_BAUDRATE		(115200)
+#define CONFIG_BAUDRATE		115200
 #define CONFIG_BOOTARGS		"root=/dev/null console=ttySC4,115200"
 #define CONFIG_INTEGRATOR
 #define CONFIG_ARCH_CINTEGRATOR