| Message ID | 1342717485-24034-1-git-send-email-mschmidt@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2012-07-19 at 19:04 +0200, Michal Schmidt wrote: > Dynamically allocated sysfs attributes must be initialized using > sysfs_attr_init(), otherwise lockdep complains: > BUG: key <address> not in .data! > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Acked-by: Ben Hutchings <bhutchings@solarflare.com> > --- > drivers/net/ethernet/sfc/mcdi_mon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/sfc/mcdi_mon.c b/drivers/net/ethernet/sfc/mcdi_mon.c > index fb7f65b..1d552f0 100644 > --- a/drivers/net/ethernet/sfc/mcdi_mon.c > +++ b/drivers/net/ethernet/sfc/mcdi_mon.c > @@ -222,6 +222,7 @@ efx_mcdi_mon_add_attr(struct efx_nic *efx, const char *name, > attr->index = index; > attr->type = type; > attr->limit_value = limit_value; > + sysfs_attr_init(&attr->dev_attr.attr); > attr->dev_attr.attr.name = attr->name; > attr->dev_attr.attr.mode = S_IRUGO; > attr->dev_attr.show = reader;
From: Ben Hutchings <bhutchings@solarflare.com> Date: Thu, 19 Jul 2012 18:19:05 +0100 > On Thu, 2012-07-19 at 19:04 +0200, Michal Schmidt wrote: >> Dynamically allocated sysfs attributes must be initialized using >> sysfs_attr_init(), otherwise lockdep complains: >> BUG: key <address> not in .data! >> >> Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > > Acked-by: Ben Hutchings <bhutchings@solarflare.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/sfc/mcdi_mon.c b/drivers/net/ethernet/sfc/mcdi_mon.c index fb7f65b..1d552f0 100644 --- a/drivers/net/ethernet/sfc/mcdi_mon.c +++ b/drivers/net/ethernet/sfc/mcdi_mon.c @@ -222,6 +222,7 @@ efx_mcdi_mon_add_attr(struct efx_nic *efx, const char *name, attr->index = index; attr->type = type; attr->limit_value = limit_value; + sysfs_attr_init(&attr->dev_attr.attr); attr->dev_attr.attr.name = attr->name; attr->dev_attr.attr.mode = S_IRUGO; attr->dev_attr.show = reader;
Dynamically allocated sysfs attributes must be initialized using sysfs_attr_init(), otherwise lockdep complains: BUG: key <address> not in .data! Signed-off-by: Michal Schmidt <mschmidt@redhat.com> --- drivers/net/ethernet/sfc/mcdi_mon.c | 1 + 1 file changed, 1 insertion(+)