Patchwork acpi: method: Change _BBN's test_type from METHOD_MOBILE to METHOD_OPTIONAL.w

login
register
mail settings
Submitter Alex Hung
Date July 19, 2012, 10:21 a.m.
Message ID <1342693313-3828-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/171916/
State Accepted
Headers show

Comments

Alex Hung - July 19, 2012, 10:21 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ivan Hu - July 20, 2012, 9:56 a.m.
On 07/19/2012 06:21 PM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/method/method.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a4ccd3a..4282616 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1446,7 +1446,7 @@ static int method_test_ALP(fwts_framework *fw)
>
>   static int method_test_BBN(fwts_framework *fw)
>   {
> -	return method_evaluate_method(fw, METHOD_MOBILE, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
> +	return method_evaluate_method(fw, METHOD_OPTIONAL, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
>   }
>
>   static int method_test_BDN(fwts_framework *fw)
>
 >
Acked-by: Ivan Hu<ivan.hu@canonical.com>
Keng-Yu Lin - July 23, 2012, 5:56 a.m.
Hi Alex,
  Any explanation why should it be METHOD_OPTIONAL? (should be good to
add in the log comment too).

-kengyu

On Thu, Jul 19, 2012 at 6:21 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a4ccd3a..4282616 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1446,7 +1446,7 @@ static int method_test_ALP(fwts_framework *fw)
>
>  static int method_test_BBN(fwts_framework *fw)
>  {
> -       return method_evaluate_method(fw, METHOD_MOBILE, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
> +       return method_evaluate_method(fw, METHOD_OPTIONAL, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
>  }
>
>  static int method_test_BDN(fwts_framework *fw)
> --
> 1.7.9.5
>
>
> --
> fwts-devel mailing list
> fwts-devel@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
Colin King - July 26, 2012, 10:46 a.m.
On 19/07/12 11:21, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/method/method.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a4ccd3a..4282616 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1446,7 +1446,7 @@ static int method_test_ALP(fwts_framework *fw)
>
>   static int method_test_BBN(fwts_framework *fw)
>   {
> -	return method_evaluate_method(fw, METHOD_MOBILE, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
> +	return method_evaluate_method(fw, METHOD_OPTIONAL, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
>   }
>
>   static int method_test_BDN(fwts_framework *fw)
>
Fixes a typo.

Acked-by: Colin Ian King <colin.king@canonical.com>

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index a4ccd3a..4282616 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -1446,7 +1446,7 @@  static int method_test_ALP(fwts_framework *fw)
 
 static int method_test_BBN(fwts_framework *fw)
 {
-	return method_evaluate_method(fw, METHOD_MOBILE, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
+	return method_evaluate_method(fw, METHOD_OPTIONAL, "_BBN", NULL, 0, method_test_integer_return, "_BBN");
 }
 
 static int method_test_BDN(fwts_framework *fw)