Patchwork [2/2] New package: cpuload

login
register
mail settings
Submitter Kelvin Cheung
Date July 19, 2012, 8:54 a.m.
Message ID <1342688049-12065-2-git-send-email-keguang.zhang@gmail.com>
Download mbox | patch
Permalink /patch/171911/
State Superseded
Headers show

Comments

Kelvin Cheung - July 19, 2012, 8:54 a.m.
Add new package: cpuload

cpuload is a simple tool to obtain intuitive vision of CPU load
(including total, user, system, irq and softirq) within a certain
time, which is especially useful for embedded system without GUI.

Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
 package/Config.in          |    1 +
 package/cpuload/Config.in  |    8 ++++++++
 package/cpuload/cpuload.mk |   11 +++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/cpuload/Config.in
 create mode 100644 package/cpuload/cpuload.mk
Thomas Petazzoni - July 19, 2012, 9:50 p.m.
Le Thu, 19 Jul 2012 16:54:09 +0800,
Kelvin Cheung <keguang.zhang@gmail.com> a écrit :

> Add new package: cpuload
> 
> cpuload is a simple tool to obtain intuitive vision of CPU load
> (including total, user, system, irq and softirq) within a certain
> time, which is especially useful for embedded system without GUI.
> 
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>

Your code includes <wchar.h>, but the package does not depend on
BR2_USE_WCHAR. Did you try to build your package with the minimal
uClibc settings (i.e wchar, IPv6, RPC, locale, etc. disabled) to see if
it builds without requiring any special toolchain feature?

Thanks,

Thomas
Kelvin Cheung - July 20, 2012, 6:05 a.m.
2012/7/20 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

> Le Thu, 19 Jul 2012 16:54:09 +0800,
> Kelvin Cheung <keguang.zhang@gmail.com> a écrit :
>
> > Add new package: cpuload
> >
> > cpuload is a simple tool to obtain intuitive vision of CPU load
> > (including total, user, system, irq and softirq) within a certain
> > time, which is especially useful for embedded system without GUI.
> >
> > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
>
> Your code includes <wchar.h>, but the package does not depend on
> BR2_USE_WCHAR. Did you try to build your package with the minimal
> uClibc settings (i.e wchar, IPv6, RPC, locale, etc. disabled) to see if
> it builds without requiring any special toolchain feature?
>

Thanks for reminding me.
I have removed the unnecessary wide-character string code in cpuload,
and upgrade it to version 0.3.

Please review the new patch.

In addtion, I have tested 'cpuload' on several architectures: x86, MIPS
and ARM. It works well so far.


>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>

Patch

diff --git a/package/Config.in b/package/Config.in
index 154b82c..817716b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -658,6 +658,7 @@  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/bootutils/Config.in"
 endif
 source "package/bwm-ng/Config.in"
+source "package/cpuload/Config.in"
 source "package/htop/Config.in"
 source "package/kmod/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
diff --git a/package/cpuload/Config.in b/package/cpuload/Config.in
new file mode 100644
index 0000000..82bc450
--- /dev/null
+++ b/package/cpuload/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_CPULOAD
+	bool "cpuload"
+	help
+	  cpuload is a simple tool to obtain intuitive vision of CPU load
+	  (including total, user, system, irq and softirq) within a certain
+	  time, which is especially useful for embedded system without GUI.
+
+	  https://github.com/kelvincheung/cpuload
diff --git a/package/cpuload/cpuload.mk b/package/cpuload/cpuload.mk
new file mode 100644
index 0000000..2cbe82a
--- /dev/null
+++ b/package/cpuload/cpuload.mk
@@ -0,0 +1,11 @@ 
+#############################################################
+#
+# cpuload
+#
+#############################################################
+
+CPULOAD_VERSION = v0.2
+CPULOAD_SITE = git://github.com/kelvincheung/cpuload.git
+
+
+$(eval $(autotools-package))