From patchwork Wed Jul 18 17:49:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 171782 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 03B202C0084 for ; Thu, 19 Jul 2012 04:19:26 +1000 (EST) Received: from localhost ([::1]:60226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrYO2-0007tY-P2 for incoming@patchwork.ozlabs.org; Wed, 18 Jul 2012 13:50:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrYNE-0005yb-J9 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 13:49:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrYND-00073r-C1 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 13:49:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrYND-00073k-4T for qemu-devel@nongnu.org; Wed, 18 Jul 2012 13:49:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6IHnI6C024428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Jul 2012 13:49:18 -0400 Received: from localhost (ovpn-113-90.phx2.redhat.com [10.3.113.90]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6IHnEHP010253; Wed, 18 Jul 2012 13:49:15 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Wed, 18 Jul 2012 14:49:14 -0300 Message-Id: <1342633760-351-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1342633760-351-1-git-send-email-lcapitulino@redhat.com> References: <1342633760-351-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH 3/9] qerror: rename QERR_QMP_EXTRA_MEMBER X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The error class name is QMPExtraInputObjectMember, not QMPExtraMember. Rename the QERR_QMP_EXTRA_MEMBER macro to QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER to reflect that, so that future error macro generation generates the expected macro name. Signed-off-by: Luiz Capitulino --- monitor.c | 2 +- qapi/qmp-dispatch.c | 2 +- qapi/qmp-input-visitor.c | 2 +- qerror.c | 2 +- qerror.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 188c03d..8427c6c 100644 --- a/monitor.c +++ b/monitor.c @@ -4434,7 +4434,7 @@ static QDict *qmp_check_input_obj(QObject *input_obj) } else if (!strcmp(arg_name, "id")) { /* FIXME: check duplicated IDs for async commands */ } else { - qerror_report(QERR_QMP_EXTRA_MEMBER, arg_name); + qerror_report(QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER, arg_name); return NULL; } } diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 122c1a2..29d6f30 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -47,7 +47,7 @@ static QDict *qmp_dispatch_check_obj(const QObject *request, Error **errp) } has_exec_key = true; } else if (strcmp(arg_name, "arguments")) { - error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); + error_set(errp, QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER, arg_name); return NULL; } } diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index 107d8d3..a59d4f6 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp-input-visitor.c @@ -104,7 +104,7 @@ static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp) if (g_hash_table_size(top_ht)) { const char *key; g_hash_table_find(top_ht, always_true, &key); - error_set(errp, QERR_QMP_EXTRA_MEMBER, key); + error_set(errp, QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER, key); } g_hash_table_unref(top_ht); } diff --git a/qerror.c b/qerror.c index a9d771b..132ab2d 100644 --- a/qerror.c +++ b/qerror.c @@ -271,7 +271,7 @@ static const QErrorStringTable qerror_table[] = { .desc = "QMP input object member '%(member)' expects '%(expected)'", }, { - .error_fmt = QERR_QMP_EXTRA_MEMBER, + .error_fmt = QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER, .desc = "QMP input object member '%(member)' is unexpected", }, { diff --git a/qerror.h b/qerror.h index 69d417d..27ce395 100644 --- a/qerror.h +++ b/qerror.h @@ -224,7 +224,7 @@ QError *qobject_to_qerror(const QObject *obj); #define QERR_QMP_BAD_INPUT_OBJECT_MEMBER \ "{ 'class': 'QMPBadInputObjectMember', 'data': { 'member': %s, 'expected': %s } }" -#define QERR_QMP_EXTRA_MEMBER \ +#define QERR_QMP_EXTRA_INPUT_OBJECT_MEMBER \ "{ 'class': 'QMPExtraInputObjectMember', 'data': { 'member': %s } }" #define QERR_RESET_REQUIRED \