Patchwork [05/11] configure: -march=i486 belongs in QEMU_CFLAGS, not CFLAGS

login
register
mail settings
Submitter Peter Maydell
Date July 18, 2012, 2:10 p.m.
Message ID <1342620628-12751-6-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/171706/
State New
Headers show

Comments

Peter Maydell - July 18, 2012, 2:10 p.m.
The distinction between QEMU_CFLAGS and CFLAGS is that the
former is for flags without which QEMU can't compile, whereas
the latter is for flags like "-g -O2" which the user can
safely override. "-march=i486" is in the former category, and
so belongs in QEMU_CFLAGS.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/configure b/configure
index f54415d..3de4ea7 100755
--- a/configure
+++ b/configure
@@ -2810,7 +2810,7 @@  int main(int argc, char **argv)
 }
 EOF
   if ! compile_prog "" "" ; then
-    CFLAGS="-march=i486 $CFLAGS"
+    QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS"
   fi
 fi