From patchwork Wed Jul 18 12:08:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kardashevskiy X-Patchwork-Id: 171659 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1CA922C0386 for ; Wed, 18 Jul 2012 22:09:16 +1000 (EST) Received: from localhost ([::1]:33431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrT46-0006nr-F7 for incoming@patchwork.ozlabs.org; Wed, 18 Jul 2012 08:09:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrT3w-0006lg-El for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:09:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrT3v-0007N5-7F for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:09:04 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrT3v-0007MJ-1G for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:09:03 -0400 Received: by pbbro12 with SMTP id ro12so2529332pbb.4 for ; Wed, 18 Jul 2012 05:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=zzrg5DKAnoMfol06VidDkOavJXXJCQ6EeJ2W2sVbZ64=; b=csLCej+ZoXjKcgoRCX4iXHL/rTk+mYmvVWWb4qcSptQ58zXhQTTZwfWFlL4L3RtRag PFMSaG+pJM2xkLqBELKabKQeI0oOkCPI/Zbp9i1/A9UsbEHqng2umKUEOj6ZpOO/Xotu s3+7LvlIVPQxU2hyryLByIsupxKqohMn/bWhZBItfu/cAF5uFwylBQaFbXQ3bNTBg3pY tlt61ZXcWHqoVZ4TnAhqAxK6CkS+PM1SyD0Wpwa0gD06/WyXhV0A8tmQOB5a2U/qKFuz Bg30BS9H7aPZvG2wYfoqZhofKGFuZmukFuP7YnH1RLuonxnZ0vjDQJ0N3IhORCnoONEI W3hA== Received: by 10.68.190.97 with SMTP id gp1mr7161825pbc.76.1342613340384; Wed, 18 Jul 2012 05:09:00 -0700 (PDT) Received: from ka1.ozlabs.ibm.com (ibmaus65.lnk.telstra.net. [165.228.126.9]) by mx.google.com with ESMTPS id rg10sm16095180pbc.54.2012.07.18.05.08.58 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jul 2012 05:08:59 -0700 (PDT) From: Alexey Kardashevskiy To: "Michael S . Tsirkin" Date: Wed, 18 Jul 2012 22:08:53 +1000 Message-Id: <1342613333-20239-1-git-send-email-aik@ozlabs.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <4FF0A980.4070903@ozlabs.ru> References: <4FF0A980.4070903@ozlabs.ru> X-Gm-Message-State: ALoCoQnWZbmHIrbNj2R2NOwbKWBx5CJ7eYUt5gOaLb7ByCxRopOR2tmqaMUgsWqFD3ufnmjkeroq X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] eventfd: making it thread safe X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org QEMU uses IO handlers to run select() in the main loop. The handlers list is managed by qemu_set_fd_handler() helper which works fine when called from the main thread as it is called not when select() is waiting. However IO handlers list can be changed in the thread other than the main one doing os_host_main_loop_wait(), for example, as a result of a hypercall which changes PCI config space (VFIO on POWER is the case) and enables/disabled MSI/MSIX which closes/creates eventfd handles. If the main loop is waiting on such eventfd, it has to be restarted. The patch adds the qemu_notify_event() call to interrupt select() and make main_loop() to restart select() with the updated IO handlers list. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Paolo Bonzini --- iohandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/iohandler.c b/iohandler.c index 3c74de6..dea4355 100644 --- a/iohandler.c +++ b/iohandler.c @@ -77,6 +77,7 @@ int qemu_set_fd_handler2(int fd, ioh->fd_write = fd_write; ioh->opaque = opaque; ioh->deleted = 0; + qemu_notify_event(); } return 0; }