From patchwork Wed Jul 18 07:00:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 171603 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id CD38E2C0354 for ; Wed, 18 Jul 2012 17:00:49 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1343199652; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=q2jgi1JZidki/eKITPzv cu0f7wQ=; b=C0xPr7HfdpYtJk2b3PKW/vWqtH2SlkFyaRpDCzKUPhsw9lHGVBjJ 92HKSeApROO6XZ40+o632Gcuaaxviu6I3KZdfSFZELtQQbm+Jt44ZmlI62ABZyHr aC8SZc++eevtu7WDVSj/psONG1EbdUAAnkBAk2E7a2539bR2AIUSWcA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=WvVVob4iJQePjxxe1/Rs2tGwU8UC0n9VCdJftrQlAuXUc8WMkWv5FrXkKSIxlk D+4rPieBmaKhSm1JrE57Vpe79Uz+0TRde37UxXtnaYzSJHO0h0gxszrlxbDdyQpZ q/RY02qL0MbcO7NPDnAi4iShIKY+z/nHIpWAXcPoDmYp4=; Received: (qmail 26073 invoked by alias); 18 Jul 2012 07:00:45 -0000 Received: (qmail 26063 invoked by uid 22791); 18 Jul 2012 07:00:44 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 07:00:25 +0000 Received: from [192.168.178.22] (port-92-204-53-225.dynamic.qsc.de [92.204.53.225]) by mx01.qsc.de (Postfix) with ESMTP id 94A0F3D041; Wed, 18 Jul 2012 09:00:18 +0200 (CEST) Message-ID: <50065EF8.4020204@net-b.de> Date: Wed, 18 Jul 2012 09:00:08 +0200 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Bosscher CC: Bernhard Reutner-Fischer , GCC Patches , Richard Guenther Subject: Re: [patch][rfc] Clean up CFG dumping References: <20120717074015.GA4194@mx.loc> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Steven, I think your patch broke bootstrapping with Graphite enabled. Tobias PS: Possible patch, I haven't checked whether "0" makes sense or something else should be used. fprintf (file, "}\n"); /projects/tob/gcc-git/gcc/gcc/graphite-poly.c: In function 'print_pbb_body': /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: warning: passing argument 1 of 'dump_bb' from incompatible pointer type [enabled by default] dump_bb (pbb_bb (pbb), file, 0); ^ In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0, from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27, from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38: /projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: expected 'struct FILE *' but argument is of type 'basic_block' extern void dump_bb (FILE *, basic_block, int, int); ^ /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: warning: passing argument 2 of 'dump_bb' from incompatible pointer type [enabled by default] dump_bb (pbb_bb (pbb), file, 0); ^ In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0, from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27, from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38: /projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: expected 'basic_block' but argument is of type 'struct FILE *' extern void dump_bb (FILE *, basic_block, int, int); ^ /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: error: too few arguments to function 'dump_bb' dump_bb (pbb_bb (pbb), file, 0); ^ In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0, from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27, from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38: /projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: declared here extern void dump_bb (FILE *, basic_block, int, int); ^ make[3]: *** [graphite-poly.o] Error 1 --- a/gcc/graphite-poly.c +++ b/gcc/graphite-poly.c @@ -675,3 +675,3 @@ print_pbb_body (FILE *file, poly_bb_p pbb, int verbosity, fprintf (file, "{\n"); - dump_bb (pbb_bb (pbb), file, 0); + dump_bb (file, pbb_bb (pbb), 0, 0);