Patchwork [rfc] Clean up CFG dumping

login
register
mail settings
Submitter Tobias Burnus
Date July 18, 2012, 7 a.m.
Message ID <50065EF8.4020204@net-b.de>
Download mbox | patch
Permalink /patch/171603/
State New
Headers show

Comments

Tobias Burnus - July 18, 2012, 7 a.m.
Steven,

I think your patch broke bootstrapping with Graphite enabled.

Tobias

PS: Possible patch, I haven't checked whether "0" makes sense or 
something else should be used.

    fprintf (file, "}\n");



/projects/tob/gcc-git/gcc/gcc/graphite-poly.c: In function 'print_pbb_body':
/projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: warning: passing 
argument 1 of 'dump_bb' from incompatible pointer type [enabled by default]
    dump_bb (pbb_bb (pbb), file, 0);
    ^
In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0,
                  from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27,
                  from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38:
/projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: expected 'struct 
FILE *' but argument is of type 'basic_block'
  extern void dump_bb (FILE *, basic_block, int, int);
              ^
/projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: warning: passing 
argument 2 of 'dump_bb' from incompatible pointer type [enabled by default]
    dump_bb (pbb_bb (pbb), file, 0);
    ^
In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0,
                  from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27,
                  from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38:
/projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: expected 
'basic_block' but argument is of type 'struct FILE *'
  extern void dump_bb (FILE *, basic_block, int, int);
              ^
/projects/tob/gcc-git/gcc/gcc/graphite-poly.c:676:3: error: too few 
arguments to function 'dump_bb'
    dump_bb (pbb_bb (pbb), file, 0);
    ^
In file included from /projects/tob/gcc-git/gcc/gcc/basic-block.h:832:0,
                  from /projects/tob/gcc-git/gcc/gcc/tree-flow.h:27,
                  from /projects/tob/gcc-git/gcc/gcc/graphite-poly.c:38:
/projects/tob/gcc-git/gcc/gcc/cfghooks.h:144:13: note: declared here
  extern void dump_bb (FILE *, basic_block, int, int);
              ^
make[3]: *** [graphite-poly.o] Error 1
Steven Bosscher - July 18, 2012, 8:10 a.m.
On Wed, Jul 18, 2012 at 9:00 AM, Tobias Burnus <burnus@net-b.de> wrote:
> Steven,
>
> I think your patch broke bootstrapping with Graphite enabled.

Yes it did. That's twice in one week, because Graphite isn't enabled
for builds on the compile farm. I'll see if I can install the
necessary libraries on the machines I use to avoid breaking Graphite
in the future.

> Tobias
>
> PS: Possible patch, I haven't checked whether "0" makes sense or something
> else should be used.

I thought this morning that 0 is fine, and I've committed the same
patch as yours a few minutes ago.

Ciao!
Steven

Patch

--- a/gcc/graphite-poly.c
+++ b/gcc/graphite-poly.c
@@ -675,3 +675,3 @@  print_pbb_body (FILE *file, poly_bb_p pbb, int 
verbosity,
    fprintf (file, "{\n");
-  dump_bb (pbb_bb (pbb), file, 0);
+  dump_bb (file, pbb_bb (pbb), 0, 0);