From patchwork Wed Jul 18 05:29:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiraz Hashim X-Patchwork-Id: 171599 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7D1592C00BE for ; Wed, 18 Jul 2012 15:33:12 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SrMpJ-0003UW-Ph; Wed, 18 Jul 2012 05:29:33 +0000 Received: from eu1sys200aog113.obsmtp.com ([207.126.144.135]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1SrMpD-0003UA-6s for linux-arm-kernel@lists.infradead.org; Wed, 18 Jul 2012 05:29:29 +0000 Received: from beta.dmz-ap.st.com ([138.198.100.35]) (using TLSv1) by eu1sys200aob113.postini.com ([207.126.147.11]) with SMTP ID DSNKUAZJrnJJT6QCFwUe8S74K2vzvAscJpnC@postini.com; Wed, 18 Jul 2012 05:29:26 UTC Received: from zeta.dmz-ap.st.com (ns6.st.com [138.198.234.13]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id E32BFA2; Wed, 18 Jul 2012 05:20:57 +0000 (GMT) Received: from Webmail-ap.st.com (eapex1hubcas2.st.com [10.80.176.10]) by zeta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 5BFA61B5B; Wed, 18 Jul 2012 05:29:14 +0000 (GMT) Received: from localhost (10.199.82.228) by Webmail-ap.st.com (10.80.176.7) with Microsoft SMTP Server (TLS) id 8.3.192.1; Wed, 18 Jul 2012 13:29:13 +0800 Date: Wed, 18 Jul 2012 10:59:11 +0530 From: Shiraz Hashim To: Olof Johansson Subject: Re: [GIT PULL] SPEAr platform fixes over 3.5-rc7 Message-ID: <20120718052911.GQ1994@localhost.localdomain> References: <20120717130150.GM1994@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [207.126.144.135 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Vipul Kumar Samar , Arnd Bergmann , viresh kumar , spear-devel@list.st.com, Stefan Roese , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Hi Olof, On Tue, Jul 17, 2012 at 08:43:34PM -0700, Olof Johansson wrote: > Hi Shiraz, > > I see that every commit in that branch is done by you, but not a > single one has a Signed-off-by by you. Please fix that, it's important > to track the history of how code is introduced to the kernel. > > Also, we are _very_ late in the 3.5 release cycle now. Only truly > critical fixes can go in (3.5 is likely to come out by the weekend). I > have some comments about the patches below. > > In general, to make our life easier, please make sure the commit > message for the patch describes why the fix is needed when it's not > obvious. > > I'll wait with pulling until you have a chance to fix up your branch > based on the below comments. Please make sure you do it with extreme > expediency though, or chances are it'll miss 3.5. I have tried to fix all points mentioned by you and updated the spear fixes branch. The following changes since commit 84a1caf1453c3d44050bd22db958af4a7f99315c: Linux 3.5-rc7 (2012-07-14 15:40:28 -0700) are available in the git repository at: http://git.stlinux.com/spear/linux-2.6.git for-3.5-spear-fixes for you to fetch changes up to 69c7e3772eaee5d2097725cdb79bc3ef867c0d9e: ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi (2012-07-18 10:05:05 +0530) ---------------------------------------------------------------- Stefan Roese (1): ARM: SPEAr600: Fix timer interrupt definition in spear600.dtsi Vipul Kumar Samar (9): clk:spear1340:Fix: Rename clk ids within predefined limit clk:spear1310:Fix: Rename clk ids within predefined limit Clk:spear3xx:Fix: Rename clk ids within predefined limit Clk:spear6xx:Fix: Rename clk ids within predefined limit ARM: SPEAr13xx: Fix Interrupt bindings clk: SPEAr1340: Fix clk enable register for uart1 and i2c1. Clk: SPEAr1340: Update sys clock parent array ARM: dts: SPEAr320: Fix compatible string ARM: dts: SPEAr320: Boot the board in EXTENDED_MODE arch/arm/boot/dts/spear13xx.dtsi | 11 +- arch/arm/boot/dts/spear320-evb.dts | 6 +- arch/arm/boot/dts/spear600.dtsi | 1 + arch/arm/mach-spear3xx/spear3xx.c | 2 +- arch/arm/mach-spear6xx/spear6xx.c | 2 +- drivers/clk/spear/spear1310_clock.c | 312 +++++++++++++++++------------------ drivers/clk/spear/spear1340_clock.c | 279 ++++++++++++++++--------------- drivers/clk/spear/spear3xx_clock.c | 180 ++++++++++---------- drivers/clk/spear/spear6xx_clock.c | 122 +++++++------- 9 files changed, 451 insertions(+), 464 deletions(-) --- regards Shiraz