Patchwork qemu-options.hx: Fix set_password and expire_password description

login
register
mail settings
Submitter Pavel Hrdina
Date July 16, 2012, 1:19 p.m.
Message ID <3d1ec0fd89b439e704cc1f6d2e7b841a64cecb47.1342436496.git.minovotn@redhat.com>
Download mbox | patch
Permalink /patch/171187/
State New
Headers show

Comments

Pavel Hrdina - July 16, 2012, 1:19 p.m.
From: Michal Novotny <minovotn@redhat.com>

The description for set_password and expire_password commands is
incomplete. This patch fixes the man page that is being generated
to match the real behaviour of these functions.

Signed-off-by: Michal Novotny <minovotn@redhat.com>
---
 qemu-options.hx |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
Michal Novotny - July 17, 2012, 8:07 a.m.
Sorry for spamming that much however I was confused why e-mail are
coming fine from Pavel Hrdina but not for me. That was the reason I
asked Pavel to send it for me as I didn't know my messages have to be
approved first because I have no recent activity on the list.

Sorry once again!
Michal

On 07/16/2012 01:05 PM, Michal Novotny wrote:
> The description for set_password and expire_password commands is
> incomplete. This patch fixes the man page that is being generated
> to match the real behaviour of these functions.
>
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  qemu-options.hx |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ecf7ca1..679e3ca 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1030,8 +1030,21 @@ is a TCP port number, not a display number.
>  @item password
>  
>  Require that password based authentication is used for client connections.
> -The password must be set separately using the @code{change} command in the
> -@ref{pcsys_monitor}
> +
> +The password must be set separately using the @code{set_password} command in
> +the @ref{pcsys_monitor}. The syntax to change your password is:
> +@code{set_password <protocol> <password>} where <protocol> could be either
> +"vnc" or "spice".
> +
> +If you would like to change <protocol> password expiration, you should use
> +@code{expire_password <protocol> <expiration-time>} where expiration time could
> +be one of the following options: now, never, +seconds or UNIX time of
> +expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
> +to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
> +date and time).
> +
> +You can also use keywords "now" or "never" for the expiration time to
> +allow <protocol> password to expire immediately or never expire.
>  
>  @item tls
>
Kevin Wolf - July 17, 2012, 1:53 p.m.
Am 16.07.2012 15:19, schrieb Pavel Hrdina:
> From: Michal Novotny <minovotn@redhat.com>
> 
> The description for set_password and expire_password commands is
> incomplete. This patch fixes the man page that is being generated
> to match the real behaviour of these functions.
> 
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  qemu-options.hx |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

This one probably qualifies for qemu-trivial, copied the list.

Kevin

> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ecf7ca1..679e3ca 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1030,8 +1030,21 @@ is a TCP port number, not a display number.
>  @item password
>  
>  Require that password based authentication is used for client connections.
> -The password must be set separately using the @code{change} command in the
> -@ref{pcsys_monitor}
> +
> +The password must be set separately using the @code{set_password} command in
> +the @ref{pcsys_monitor}. The syntax to change your password is:
> +@code{set_password <protocol> <password>} where <protocol> could be either
> +"vnc" or "spice".
> +
> +If you would like to change <protocol> password expiration, you should use
> +@code{expire_password <protocol> <expiration-time>} where expiration time could
> +be one of the following options: now, never, +seconds or UNIX time of
> +expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
> +to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
> +date and time).
> +
> +You can also use keywords "now" or "never" for the expiration time to
> +allow <protocol> password to expire immediately or never expire.
>  
>  @item tls
>

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index ecf7ca1..679e3ca 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1030,8 +1030,21 @@  is a TCP port number, not a display number.
 @item password
 
 Require that password based authentication is used for client connections.
-The password must be set separately using the @code{change} command in the
-@ref{pcsys_monitor}
+
+The password must be set separately using the @code{set_password} command in
+the @ref{pcsys_monitor}. The syntax to change your password is:
+@code{set_password <protocol> <password>} where <protocol> could be either
+"vnc" or "spice".
+
+If you would like to change <protocol> password expiration, you should use
+@code{expire_password <protocol> <expiration-time>} where expiration time could
+be one of the following options: now, never, +seconds or UNIX time of
+expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
+to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
+date and time).
+
+You can also use keywords "now" or "never" for the expiration time to
+allow <protocol> password to expire immediately or never expire.
 
 @item tls