Patchwork [2/6] mtd: s3c2410: Use pr_* instead of printk

login
register
mail settings
Submitter Sachin Kamat
Date July 16, 2012, 10:32 a.m.
Message ID <1342434747-27622-2-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/171152/
State New
Headers show

Comments

Sachin Kamat - July 16, 2012, 10:32 a.m.
Use pr_* instead of printk.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mtd/nand/s3c2410.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Artem Bityutskiy - Aug. 19, 2012, 11:07 a.m.
On Mon, 2012-07-16 at 16:02 +0530, Sachin Kamat wrote:
>  #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG
>  #define DEBUG
>  #endif
> @@ -215,7 +217,8 @@ static int s3c_nand_calc_rate(int wanted, unsigned long clk, int max)
>  	pr_debug("result %d from %ld, %d\n", result, clk, wanted);
>  
>  	if (result > max) {
> -		printk("%d ns is too big for current clock rate %ld\n", wanted, clk);
> +		pr_err("%d ns is too big for current clock rate %ld\n",
> +								wanted, clk);

I've removed tabs to make "wanted" more aligned with where the format
string starts, and pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 8f9267f..2383940 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -21,6 +21,8 @@ 
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */
 
+#define pr_fmt(fmt) "nand-s3c2410: " fmt
+
 #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG
 #define DEBUG
 #endif
@@ -215,7 +217,8 @@  static int s3c_nand_calc_rate(int wanted, unsigned long clk, int max)
 	pr_debug("result %d from %ld, %d\n", result, clk, wanted);
 
 	if (result > max) {
-		printk("%d ns is too big for current clock rate %ld\n", wanted, clk);
+		pr_err("%d ns is too big for current clock rate %ld\n",
+								wanted, clk);
 		return -1;
 	}