Patchwork QEMU VNC Audio - All audio data null

login
register
mail settings
Submitter malc
Date July 16, 2012, 12:03 a.m.
Message ID <alpine.LNX.2.00.1207160402410.6203@linmac>
Download mbox | patch
Permalink /patch/171111/
State New
Headers show

Comments

malc - July 16, 2012, 12:03 a.m.
On Sun, 15 Jul 2012, agraham wrote:

[..snip..]

> 
> I've found the root cause and hopefully you should be able to reproduce the
> issue.
> 
> There was a configure option introduced called "--enable-mixemu".
> 
> --enable-mixemu          enable mixer emulation

Try this


[..snip..]
agraham - July 16, 2012, 2:10 a.m.
On 07/16/2012 01:03 AM, malc wrote:
> On Sun, 15 Jul 2012, agraham wrote:
>
> [..snip..]
>
>>
>> I've found the root cause and hopefully you should be able to reproduce the
>> issue.
>>
>> There was a configure option introduced called "--enable-mixemu".
>>
>> --enable-mixemu          enable mixer emulation
>
> Try this
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 583ee51..1c77389 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -818,6 +818,7 @@ static int audio_attach_capture (HWVoiceOut *hw)
>           sw->active = hw->enabled;
>           sw->conv = noop_conv;
>           sw->ratio = ((int64_t) hw_cap->info.freq<<  32) / sw->info.freq;
> +        sw->vol = nominal_volume;
>           sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
>           if (!sw->rate) {
>               dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));
>
> [..snip..]
>

:)

I'm as happy as Larry, works great,

Thank you so much.

Albert.
Daniel P. Berrange - July 16, 2012, 8:12 a.m.
On Mon, Jul 16, 2012 at 03:10:25AM +0100, agraham wrote:
> On 07/16/2012 01:03 AM, malc wrote:
> >On Sun, 15 Jul 2012, agraham wrote:
> >
> >[..snip..]
> >
> >>
> >>I've found the root cause and hopefully you should be able to reproduce the
> >>issue.
> >>
> >>There was a configure option introduced called "--enable-mixemu".
> >>
> >>--enable-mixemu          enable mixer emulation
> >
> >Try this
> >
> >diff --git a/audio/audio.c b/audio/audio.c
> >index 583ee51..1c77389 100644
> >--- a/audio/audio.c
> >+++ b/audio/audio.c
> >@@ -818,6 +818,7 @@ static int audio_attach_capture (HWVoiceOut *hw)
> >          sw->active = hw->enabled;
> >          sw->conv = noop_conv;
> >          sw->ratio = ((int64_t) hw_cap->info.freq<<  32) / sw->info.freq;
> >+        sw->vol = nominal_volume;
> >          sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
> >          if (!sw->rate) {
> >              dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));
> >
> >[..snip..]
> >
> 
> :)
> 
> I'm as happy as Larry, works great,

Please do file a bug against Fedora for this problem, so that our
maintainers sort it out


Daniel
agraham - July 16, 2012, 10:56 a.m.
On 07/16/2012 09:12 AM, Daniel P. Berrange wrote:
> On Mon, Jul 16, 2012 at 03:10:25AM +0100, agraham wrote:
>> On 07/16/2012 01:03 AM, malc wrote:
>>> On Sun, 15 Jul 2012, agraham wrote:
>>>
>>> [..snip..]
>>>
>>>>
>>>> I've found the root cause and hopefully you should be able to reproduce the
>>>> issue.
>>>>
>>>> There was a configure option introduced called "--enable-mixemu".
>>>>
>>>> --enable-mixemu          enable mixer emulation
>>>
>>> Try this
>>>
>>> diff --git a/audio/audio.c b/audio/audio.c
>>> index 583ee51..1c77389 100644
>>> --- a/audio/audio.c
>>> +++ b/audio/audio.c
>>> @@ -818,6 +818,7 @@ static int audio_attach_capture (HWVoiceOut *hw)
>>>           sw->active = hw->enabled;
>>>           sw->conv = noop_conv;
>>>           sw->ratio = ((int64_t) hw_cap->info.freq<<   32) / sw->info.freq;
>>> +        sw->vol = nominal_volume;
>>>           sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
>>>           if (!sw->rate) {
>>>               dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));
>>>
>>> [..snip..]
>>>
>>
>> :)
>>
>> I'm as happy as Larry, works great,
>
> Please do file a bug against Fedora for this problem, so that our
> maintainers sort it out
>
>
> Daniel

Will do.

Hey, your blog rocks!

Albert
agraham - July 16, 2012, 7:58 p.m.
On 07/16/2012 09:12 AM, Daniel P. Berrange wrote:
> On Mon, Jul 16, 2012 at 03:10:25AM +0100, agraham wrote:
>> On 07/16/2012 01:03 AM, malc wrote:
>>> On Sun, 15 Jul 2012, agraham wrote:
>>>
>>> [..snip..]
>>>
>>>>
>>>> I've found the root cause and hopefully you should be able to reproduce the
>>>> issue.
>>>>
>>>> There was a configure option introduced called "--enable-mixemu".
>>>>
>>>> --enable-mixemu          enable mixer emulation
>>>
>>> Try this
>>>
>>> diff --git a/audio/audio.c b/audio/audio.c
>>> index 583ee51..1c77389 100644
>>> --- a/audio/audio.c
>>> +++ b/audio/audio.c
>>> @@ -818,6 +818,7 @@ static int audio_attach_capture (HWVoiceOut *hw)
>>>           sw->active = hw->enabled;
>>>           sw->conv = noop_conv;
>>>           sw->ratio = ((int64_t) hw_cap->info.freq<<   32) / sw->info.freq;
>>> +        sw->vol = nominal_volume;
>>>           sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
>>>           if (!sw->rate) {
>>>               dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));
>>>
>>> [..snip..]
>>>
>>
>> :)
>>
>> I'm as happy as Larry, works great,
>
> Please do file a bug against Fedora for this problem, so that our
> maintainers sort it out
>
>
> Daniel

done.

https://bugzilla.redhat.com/show_bug.cgi?id=840653

Patch

diff --git a/audio/audio.c b/audio/audio.c
index 583ee51..1c77389 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -818,6 +818,7 @@  static int audio_attach_capture (HWVoiceOut *hw)
         sw->active = hw->enabled;
         sw->conv = noop_conv;
         sw->ratio = ((int64_t) hw_cap->info.freq << 32) / sw->info.freq;
+        sw->vol = nominal_volume;
         sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
         if (!sw->rate) {
             dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));