Patchwork PATCH: PR target/53383: Allow -mpreferred-stack-boundary=3 on x86-64

login
register
mail settings
Submitter Gerald Pfeifer
Date July 15, 2012, 9:49 p.m.
Message ID <alpine.LNX.2.00.1207152316560.5035@gerinyyl.fvgr>
Download mbox | patch
Permalink /patch/171107/
State New
Headers show

Comments

Gerald Pfeifer - July 15, 2012, 9:49 p.m.
On Fri, 22 Jun 2012, H.J. Lu wrote:
> I am not sure if news.html is the best place for this.

news.html definitely is not a good place for this, cf. the comment
  <!-- ATTENTION: This page is for *OLD* news!  Latest news goes first. -->
in that file. ;-)

> How about putting it in gcc-4.8/changes.html?

Yes, that fits.

> Does it look OK?

Patch

Index: ./gcc-4.8/changes.html
===================================================================
+    <li>Allow <code>-mpreferred-stack-boundary=3</code> for the x86-64
+    architecture with SSE extensions disabled.  Since x86-64 ABI require

the...ABI
requires

+    used in controlled environment where stack space is important limitation.

is an important limitation

+    long double and __int128), leading to wrong results.  You must build all

<code>...</code>

And the header for the supersection was missing.  

All fixed with the patch below which I committed.


Index: gcc-4.8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v
retrieving revision 1.4
diff -u -3 -p -r1.4 changes.html
--- gcc-4.8/changes.html	2 Jul 2012 11:35:28 -0000	1.4
+++ gcc-4.8/changes.html	15 Jul 2012 21:23:19 -0000
@@ -63,22 +63,22 @@  more information about requirements to b
 <h3>Java (GCJ)</h3>
 -->
 
-<!--
 <h2 id="targets">New Targets and Target Specific Improvements</h2>
--->
 
 <h3>IA-32/x86-64</h3>
   <ul>
     <li>Allow <code>-mpreferred-stack-boundary=3</code> for the x86-64
-    architecture with SSE extensions disabled.  Since x86-64 ABI require
-    16 byte stack alignment, this is ABI incompatible and intended to be
-    used in controlled environment where stack space is important limitation.
+    architecture with SSE extensions disabled.  Since the x86-64 ABI
+    requires 16 byte stack alignment, this is ABI incompatible and
+    intended to be used in controlled environments where stack space
+    is an important limitation.
     This option will lead to wrong code when functions compiled with 16 byte
     stack alignment (such as functions from a standard library) are called
     with misaligned stack.  In this case, SSE instructions may lead to
     misaligned memory access traps.  In addition, variable arguments will
     be handled incorrectly for 16 byte aligned objects (including x87
-    long double and __int128), leading to wrong results.  You must build all
+    <code>long double</code> and <code>__int128</code>), leading to
+    wrong results.  You must build all
     modules with <code>-mpreferred-stack-boundary=3</code>, including any
     libraries.  This includes the system libraries and startup modules.</li>
   </ul>