From patchwork Sun Jul 15 20:25:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 171090 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 681462C00DA for ; Mon, 16 Jul 2012 06:25:48 +1000 (EST) Received: from localhost ([::1]:44769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqVNw-0001EE-Tk for incoming@patchwork.ozlabs.org; Sun, 15 Jul 2012 16:25:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqVNp-0001E8-JR for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqVNo-00083I-Ir for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:37 -0400 Received: from vms173011pub.verizon.net ([206.46.173.11]:35736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqVNo-00083D-E0 for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:36 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173011.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M7700KFKY29XE60@vms173011.mailsrvcs.net> for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:25:24 -0500 (CDT) Received: from i.minyard.home (i2.minyard.home [192.168.27.116]) by wf-rch.minyard.home (Postfix) with ESMTP id C78821F956; Sun, 15 Jul 2012 15:25:13 -0500 (CDT) Received: by i.minyard.home (Postfix, from userid 1000) id A390981840; Sun, 15 Jul 2012 15:25:12 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Sun, 15 Jul 2012 15:25:05 -0500 Message-id: <1342383911-6094-10-git-send-email-minyard@acm.org> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1342383911-6094-1-git-send-email-minyard@acm.org> References: <1342383911-6094-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Solaris 10 (1203?) X-Received-From: 206.46.173.11 Cc: Corey Minyard Subject: [Qemu-devel] [PATCH 10/16] qom: release previous object when setting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Corey Minyard When setting an object, if you don't release the previous object that was there, it may become unusable. This change allows a chardev to be removed from one object's properties and added to another's. Acked-by: Paolo Bonzini --- qom/object.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index 00bb3b0..484dc77 100644 --- a/qom/object.c +++ b/qom/object.c @@ -731,6 +731,8 @@ void object_property_set(Object *obj, Visitor *v, const char *name, if (!prop->set) { error_set(errp, QERR_PERMISSION_DENIED); } else { + if (prop->release) + prop->release(obj, name, prop->opaque); prop->set(obj, v, prop->opaque, name, errp); } }