From patchwork Sun Jul 15 20:26:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 171087 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 989B72C00DB for ; Mon, 16 Jul 2012 05:25:56 +1000 (EST) Received: from localhost ([::1]:58380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqUS2-0006Yo-Ml for incoming@patchwork.ozlabs.org; Sun, 15 Jul 2012 15:25:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqURw-0006YV-Vt for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:25:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqURv-0000MX-Al for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:25:48 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:56519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqURv-0000MT-3P for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:25:47 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 3F86C1B4152 for ; Sun, 15 Jul 2012 19:25:46 +0000 (UTC) From: Mike Frysinger To: qemu-devel@nongnu.org Date: Sun, 15 Jul 2012 16:26:12 -0400 Message-Id: <1342383972-11640-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.7.9.7 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 140.211.166.183 Subject: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and deviates from how we treat all other toolchain variables that we get from the environment. Ultimately, the point is that it breaks passing custom flags directly to pkg-config via the env var where this normally works elsewhere, and it used to work in the past. Signed-off-by: Mike Frysinger --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 83fa1ca..bd12ed3 100755 --- a/configure +++ b/configure @@ -245,7 +245,7 @@ strip="${STRIP-${cross_prefix}strip}" windres="${WINDRES-${cross_prefix}windres}" pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}" query_pkg_config() { - "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@" + ${pkg_config_exe} ${QEMU_PKG_CONFIG_FLAGS} "$@" } pkg_config=query_pkg_config sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}" @@ -1511,7 +1511,7 @@ fi ########################################## # pkg-config probe -if ! has "$pkg_config_exe"; then +if ! has $pkg_config_exe; then echo "Error: pkg-config binary '$pkg_config_exe' not found" exit 1 fi