Patchwork [v2] libplayer: fix handling of cflags in configure

login
register
mail settings
Submitter Arnout Vandecappelle
Date July 14, 2012, 9:34 p.m.
Message ID <1342301676-23857-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/171027/
State Accepted
Headers show

Comments

Arnout Vandecappelle - July 14, 2012, 9:34 p.m.
Problem was found when compiling libplayer with GStreamer support
on x86_64 with a Sourcery toolchain.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v2: document error situation in commit log
 .../libplayer/libplayer-fix-configure-cflags.patch |   41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)
Thomas Petazzoni - July 15, 2012, 7:51 p.m.
Le Sat, 14 Jul 2012 23:34:36 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a écrit :

> Problem was found when compiling libplayer with GStreamer support
> on x86_64 with a Sourcery toolchain.

I've tried to build libplayer with gstreamer support for x86_64 with a
Sourcery toolchain, and I didn't had an issue. Since your problem was
quoting related, I thought that it could be caused by the ccache
support, but it isn't.

Can you post the .config that triggers the problem, or provide more
details on the problem? It's not that I don't believe that there is a
problem, but without producing it, I feel a bit out of infos to review
the patch.

Thanks!

Thomas
Arnout Vandecappelle - July 17, 2012, 10:47 a.m.
On 07/15/12 21:51, Thomas Petazzoni wrote:
> Le Sat, 14 Jul 2012 23:34:36 +0200,
> "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>  a écrit :
>
>> Problem was found when compiling libplayer with GStreamer support
>> on x86_64 with a Sourcery toolchain.
>
> I've tried to build libplayer with gstreamer support for x86_64 with a
> Sourcery toolchain, and I didn't had an issue. Since your problem was
> quoting related, I thought that it could be caused by the ccache
> support, but it isn't.
>
> Can you post the .config that triggers the problem, or provide more
> details on the problem? It's not that I don't believe that there is a
> problem, but without producing it, I feel a bit out of infos to review
> the patch.

  The config is an allpackageyesconfig from which I removed a few packages
that don't work on x86_64 or that can't be downloaded anymore.  I've attached
the defconfig.  You'd best interrupt the build after the cross-compiler is
extracted and then run 'make libplayer' explicitly, or you'll have to wait
for hours for the build to finish...


  Regards,
  Arnout
Peter Korsgaard - Oct. 22, 2012, 7:50 a.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 Arnout> On 07/15/12 21:51, Thomas Petazzoni wrote:
 >> Le Sat, 14 Jul 2012 23:34:36 +0200,
 >> "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>  a écrit :
 >> 
 >>> Problem was found when compiling libplayer with GStreamer support
 >>> on x86_64 with a Sourcery toolchain.
 >> 
 >> I've tried to build libplayer with gstreamer support for x86_64 with a
 >> Sourcery toolchain, and I didn't had an issue. Since your problem was
 >> quoting related, I thought that it could be caused by the ccache
 >> support, but it isn't.
 >> 
 >> Can you post the .config that triggers the problem, or provide more
 >> details on the problem? It's not that I don't believe that there is a
 >> problem, but without producing it, I feel a bit out of infos to review
 >> the patch.

 Arnout>  The config is an allpackageyesconfig from which I removed a
 Arnout> few packages that don't work on x86_64 or that can't be
 Arnout> downloaded anymore.  I've attached the defconfig.  You'd best
 Arnout> interrupt the build after the cross-compiler is extracted and
 Arnout> then run 'make libplayer' explicitly, or you'll have to wait
 Arnout> for hours for the build to finish...

Committed, thanks. The issue also triggered on the autobuilder
yesterday:

http://autobuild.buildroot.net/results/2a22f33410197f5cf546bf1974c2e168d1b1a070/build-end.log

Patch

diff --git a/package/libplayer/libplayer-fix-configure-cflags.patch b/package/libplayer/libplayer-fix-configure-cflags.patch
new file mode 100644
index 0000000..186afd5
--- /dev/null
+++ b/package/libplayer/libplayer-fix-configure-cflags.patch
@@ -0,0 +1,41 @@ 
+From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+Subject: [PATCH] libplayer: Fix handling of cflags in configure.
+
+The cflags returned by pkg-config or another config script may consist
+of several arguments for the compiler.  These should not be quoted together
+into a single argument.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+---
+Sent upstream to devel@geexbox.org on July 11, 2012.
+---
+diff -rup libplayer-2.0.1.orig/configure libplayer-2.0.1/configure
+--- libplayer-2.0.1.orig/configure	2010-10-03 19:26:11.000000000 +0200
++++ libplayer-2.0.1/configure	2012-07-10 23:33:02.783701852 +0200
+@@ -342,7 +342,7 @@ check_libconfig(){
+   err=1
+   if `which "$config" 1>/dev/null 2>&1`; then
+     cflags=`$config $ccflags`
+-    [ -n "$cflags" ] && check_cflags "$cflags"
++    [ -n "$cflags" ] && check_cflags $cflags
+     libs=`$config $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"
+@@ -364,7 +364,7 @@ check_libconfig_exists(){
+   err=1
+   if `which "$config" 1>/dev/null 2>&1`; then
+     cflags=`$config $ccflags`
+-    [ -n "$cflags" ] && temp_cflags "$cflags"
++    [ -n "$cflags" ] && temp_cflags $cflags
+     libs=`$config $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"
+@@ -386,7 +386,7 @@ check_pkgconfig(){
+   err=1
+   if `which pkg-config 1>/dev/null 2>&1`; then
+     cflags=`pkg-config $pkg $ccflags`
+-    [ -n "$cflags" ] && check_cflags "$cflags"
++    [ -n "$cflags" ] && check_cflags $cflags
+     libs=`pkg-config $pkg $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"