Patchwork media: mx2_camera: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags.

login
register
mail settings
Submitter Javier Martin
Date July 12, 2012, 9:03 a.m.
Message ID <1342083809-19921-1-git-send-email-javier.martin@vista-silicon.com>
Download mbox | patch
Permalink /patch/170615/
State New
Headers show

Comments

Javier Martin - July 12, 2012, 9:03 a.m.
These flags are not used any longer and can be safely removed
since the following patch:
http://www.spinics.net/lists/linux-media/msg50165.html

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
---
 arch/arm/plat-mxc/include/mach/mx2_cam.h |    2 --
 1 file changed, 2 deletions(-)
Laurent Pinchart - July 15, 2012, 12:11 p.m.
Hi Javier,

On Thursday 12 July 2012 11:03:29 Javier Martin wrote:
> These flags are not used any longer and can be safely removed
> since the following patch:
> http://www.spinics.net/lists/linux-media/msg50165.html
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>

I would replace the URL with the commit ID in mainline. Apart from that,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Guennadi Liakhovetski - July 20, 2012, 11:31 a.m.
On Thu, 12 Jul 2012, Javier Martin wrote:

> These flags are not used any longer and can be safely removed
> since the following patch:
> http://www.spinics.net/lists/linux-media/msg50165.html
> 
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>

For the ARM tree:

Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks
Guennadi

> ---
>  arch/arm/plat-mxc/include/mach/mx2_cam.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/include/mach/mx2_cam.h b/arch/arm/plat-mxc/include/mach/mx2_cam.h
> index 3c080a3..7ded6f1 100644
> --- a/arch/arm/plat-mxc/include/mach/mx2_cam.h
> +++ b/arch/arm/plat-mxc/include/mach/mx2_cam.h
> @@ -23,7 +23,6 @@
>  #ifndef __MACH_MX2_CAM_H_
>  #define __MACH_MX2_CAM_H_
>  
> -#define MX2_CAMERA_SWAP16		(1 << 0)
>  #define MX2_CAMERA_EXT_VSYNC		(1 << 1)
>  #define MX2_CAMERA_CCIR			(1 << 2)
>  #define MX2_CAMERA_CCIR_INTERLACE	(1 << 3)
> @@ -31,7 +30,6 @@
>  #define MX2_CAMERA_GATED_CLOCK		(1 << 5)
>  #define MX2_CAMERA_INV_DATA		(1 << 6)
>  #define MX2_CAMERA_PCLK_SAMPLE_RISING	(1 << 7)
> -#define MX2_CAMERA_PACK_DIR_MSB		(1 << 8)
>  
>  /**
>   * struct mx2_camera_platform_data - optional platform data for mx2_camera
> -- 
> 1.7.9.5
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Javier Martin - July 30, 2012, 12:55 p.m.
Hi,
thank you for yor ACKs.

On 20 July 2012 13:31, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> On Thu, 12 Jul 2012, Javier Martin wrote:
>
>> These flags are not used any longer and can be safely removed
>> since the following patch:
>> http://www.spinics.net/lists/linux-media/msg50165.html
>>
>> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>
> For the ARM tree:
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

forgive my ignorance on the matter. Could you please point me to the
git repository this patch should be merged?

Regards.
Guennadi Liakhovetski - July 30, 2012, 3:33 p.m.
Hi Javier

On Mon, 30 Jul 2012, javier Martin wrote:

> Hi,
> thank you for yor ACKs.
> 
> On 20 July 2012 13:31, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > On Thu, 12 Jul 2012, Javier Martin wrote:
> >
> >> These flags are not used any longer and can be safely removed
> >> since the following patch:
> >> http://www.spinics.net/lists/linux-media/msg50165.html
> >>
> >> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> >
> > For the ARM tree:
> >
> > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> 
> forgive my ignorance on the matter. Could you please point me to the
> git repository this patch should be merged?

Sorry, my "for the ARM tree" comment was probably not clear enough. This 
patch should certainly go via the ARM (SoC) tree, since it only touches 
arch/arm. So, the maintainer (Sascha - added to CC), that will be 
forwarding this patch to Linus can thereby add my "acked-by" to this 
patch, if he feels like it.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Javier Martin - Aug. 20, 2012, 8:08 a.m.
Hi,

On 30 July 2012 17:33, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> Hi Javier
>
> On Mon, 30 Jul 2012, javier Martin wrote:
>
>> Hi,
>> thank you for yor ACKs.
>>
>> On 20 July 2012 13:31, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
>> > On Thu, 12 Jul 2012, Javier Martin wrote:
>> >
>> >> These flags are not used any longer and can be safely removed
>> >> since the following patch:
>> >> http://www.spinics.net/lists/linux-media/msg50165.html
>> >>
>> >> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>> >
>> > For the ARM tree:
>> >
>> > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>> forgive my ignorance on the matter. Could you please point me to the
>> git repository this patch should be merged?
>
> Sorry, my "for the ARM tree" comment was probably not clear enough. This
> patch should certainly go via the ARM (SoC) tree, since it only touches
> arch/arm. So, the maintainer (Sascha - added to CC), that will be
> forwarding this patch to Linus can thereby add my "acked-by" to this
> patch, if he feels like it.
>

Sascha, do you have any comments on this one? I can't find it in
arm-soc, did you already merge it?

Regards.
Robert Schwebel - Aug. 20, 2012, 6:15 p.m.
On Mon, Aug 20, 2012 at 10:08:39AM +0200, javier Martin wrote:
> Sascha, do you have any comments on this one? I can't find it in
> arm-soc, did you already merge it?

Sascha is not in the office this week.

rsc
Sascha Hauer - Aug. 28, 2012, 9:35 a.m.
On Mon, Aug 20, 2012 at 10:08:39AM +0200, javier Martin wrote:
> Hi,
> 
> On 30 July 2012 17:33, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > Hi Javier
> >
> > On Mon, 30 Jul 2012, javier Martin wrote:
> >
> >> Hi,
> >> thank you for yor ACKs.
> >>
> >> On 20 July 2012 13:31, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> >> > On Thu, 12 Jul 2012, Javier Martin wrote:
> >> >
> >> >> These flags are not used any longer and can be safely removed
> >> >> since the following patch:
> >> >> http://www.spinics.net/lists/linux-media/msg50165.html
> >> >>
> >> >> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> >> >
> >> > For the ARM tree:
> >> >
> >> > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >>
> >> forgive my ignorance on the matter. Could you please point me to the
> >> git repository this patch should be merged?
> >
> > Sorry, my "for the ARM tree" comment was probably not clear enough. This
> > patch should certainly go via the ARM (SoC) tree, since it only touches
> > arch/arm. So, the maintainer (Sascha - added to CC), that will be
> > forwarding this patch to Linus can thereby add my "acked-by" to this
> > patch, if he feels like it.
> >
> 
> Sascha, do you have any comments on this one? I can't find it in
> arm-soc, did you already merge it?

Applied, thanks. I have rewritten the commit message as follows:

Author: Javier Martin <javier.martin@vista-silicon.com>
Date:   Thu Jul 12 11:03:29 2012 +0200

    ARM i.MX mx2_camera: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags.
    
    These flags are not used any longer and can be safely removed
    since:
    
    | commit 8a76e5383fb5f58868fdd3a2fe1f4b95988f10a8
    | Author: Javier Martin <javier.martin@vista-silicon.com>
    | Date:   Wed Jul 11 17:34:54 2012 +0200
    |
    |    media: mx2_camera: Fix mbus format handling
    
    Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
    Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

Patch

diff --git a/arch/arm/plat-mxc/include/mach/mx2_cam.h b/arch/arm/plat-mxc/include/mach/mx2_cam.h
index 3c080a3..7ded6f1 100644
--- a/arch/arm/plat-mxc/include/mach/mx2_cam.h
+++ b/arch/arm/plat-mxc/include/mach/mx2_cam.h
@@ -23,7 +23,6 @@ 
 #ifndef __MACH_MX2_CAM_H_
 #define __MACH_MX2_CAM_H_
 
-#define MX2_CAMERA_SWAP16		(1 << 0)
 #define MX2_CAMERA_EXT_VSYNC		(1 << 1)
 #define MX2_CAMERA_CCIR			(1 << 2)
 #define MX2_CAMERA_CCIR_INTERLACE	(1 << 3)
@@ -31,7 +30,6 @@ 
 #define MX2_CAMERA_GATED_CLOCK		(1 << 5)
 #define MX2_CAMERA_INV_DATA		(1 << 6)
 #define MX2_CAMERA_PCLK_SAMPLE_RISING	(1 << 7)
-#define MX2_CAMERA_PACK_DIR_MSB		(1 << 8)
 
 /**
  * struct mx2_camera_platform_data - optional platform data for mx2_camera