From patchwork Wed Jul 11 15:03:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [precise, SRU, Lenovo, IdeaPad, U300s, Conexant, CX20590, Mic, Internal] Background noise or low volume (phase inversion) Date: Wed, 11 Jul 2012 05:03:18 -0000 From: Chris J Arges X-Patchwork-Id: 170479 Message-Id: <4FFD95B6.6000609@canonical.com> To: Ubuntu Kernel Team BugLink: http://launchpad.net/bugs/903853 Precise SRU Justification: Impact: IdeaPad U300s's microphone is quiet/noisy. Fix: These patches by David Henningsson in Quantal were backported to Precise. Testcase: Using the IdeaPad U300s, try capturing audio using the microphone and ensure it works properly. 2 Patches Attached. Thanks, --chris j arges Acked-by: Andy Whitcroft >From 42fadf694099746db0ddeac03f95d79ebcd82bf1 Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Tue, 10 Apr 2012 13:05:29 +0200 Subject: [PATCH 2/2] ALSA: hda - Fix oops caused by recent commit "Fix internal mic for Lenovo Ideapad U300s" Make sure we don't dereference the "quirk" pointer when it is null. Reported-by: Dan Carpenter Signed-off-by: David Henningsson Signed-off-by: Takashi Iwai (cherry picked from commit 83b0c6ba999643ee8ad6329f26e1cdc870e1a920) BugLink: https://bugs.launchpad.net/bugs/903853 Signed-off-by: Chris J Arges --- sound/pci/hda/patch_conexant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index ad4d757..7b7399e 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -4418,7 +4418,9 @@ static void apply_fixup(struct hda_codec *codec, struct conexant_spec *spec = codec->spec; quirk = snd_pci_quirk_lookup(codec->bus->pci, quirk); - if (quirk && table[quirk->value]) { + if (!quirk) + return; + if (table[quirk->value]) { snd_printdd(KERN_INFO "hda_codec: applying pincfg for %s\n", quirk->name); apply_pincfg(codec, table[quirk->value]); -- 1.7.9.5