From patchwork Wed Jul 11 10:31:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasilis Liaskovitis X-Patchwork-Id: 170422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7F0442C01F1 for ; Wed, 11 Jul 2012 20:32:44 +1000 (EST) Received: from localhost ([::1]:38585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SouDq-0003Uw-7l for incoming@patchwork.ozlabs.org; Wed, 11 Jul 2012 06:32:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SouDW-0003Kg-Rt for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SouDP-0005pd-Ie for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:22 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:57641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SouDP-0005nm-Ct for qemu-devel@nongnu.org; Wed, 11 Jul 2012 06:32:15 -0400 Received: by mail-bk0-f45.google.com with SMTP id ji1so712841bkc.4 for ; Wed, 11 Jul 2012 03:32:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=eakg4f1Cep30TuH/vw6lmEQm2gNaNqfaX3tRHZRiymI=; b=XhkfaBHKDqau4/8Kg+a7C/02G+kg8Xo/UO5/tx8SF5lOVpxYRpHxMIVzGpnqccVesV LI3tDYmwwbOG+s1tcqCibzbVsnUFayNO4b8bkzePX+elb5I4IbbG2BJyIHrWQnIlQs8c qH1rzh9cjtr8hMeQDwuSHIkMaS5UPLPVS9NfgytfWKy+m9AovBAMzfH//7enuJuPQ66U 5D9ePOFY0ZfNqVnWY4Jc8WcUiYN7LC6ppH5GLEW6Iu7eRlDfm+JaLul7U1TW39IX2uYb 5qkwXcy7dpbjBN4gwgQsRunsMAPjpvSxc03Zbogt4Wt6xeWbqHWREa9H6fo8owIm/Qmr SI7w== Received: by 10.205.127.77 with SMTP id gz13mr18859093bkc.17.1342002734309; Wed, 11 Jul 2012 03:32:14 -0700 (PDT) Received: from dhcp-192-168-178-175.ri.profitbricks.localdomain ([62.217.45.26]) by mx.google.com with ESMTPS id e20sm794740bkv.10.2012.07.11.03.32.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 Jul 2012 03:32:13 -0700 (PDT) From: Vasilis Liaskovitis To: qemu-devel@nongnu.org, kvm@vger.kernel.org, seabios@seabios.org Date: Wed, 11 Jul 2012 12:31:50 +0200 Message-Id: <1342002726-18258-6-git-send-email-vasilis.liaskovitis@profitbricks.com> X-Mailer: git-send-email 1.7.9 In-Reply-To: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> X-Gm-Message-State: ALoCoQkSRN+ZQUhf4rh0p7vQvATzrJnlatNMopUvX4Qzu2/c8Hlhg+bXUCphXYmUYW8cAwR0MTSk X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.45 Cc: gleb@redhat.com, Vasilis Liaskovitis , kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com Subject: [Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe0000000). Otherwise, the guest cannot online new dimms at those ranges due to pci_root window conflicts. (workaround for linux guest is booting with pci=nocrs) Signed-off-by: Vasilis Liaskovitis --- src/pciinit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 68f302a..0b11cbe 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -592,7 +592,7 @@ static void pci_region_map_entries(struct pci_bus *busses, struct pci_region *r) static void pci_bios_map_devices(struct pci_bus *busses) { - pcimem_start = RamSize; + pcimem_start = BUILD_PCIMEM_START; if (pci_bios_init_root_regions(busses)) { struct pci_region r64_mem, r64_pref;