Patchwork [6/8] scsi-disk: fix changeable values for MODE_PAGE_R_W_ERROR

login
register
mail settings
Submitter Paolo Bonzini
Date July 10, 2012, 2:15 p.m.
Message ID <1341929710-21574-7-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/170200/
State New
Headers show

Comments

Paolo Bonzini - July 10, 2012, 2:15 p.m.
The changeable values were not all-zeros for this mode page, fix it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-disk.c |    3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e64d659..a7f1f14 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -1058,6 +1058,9 @@  static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf,
 
     case MODE_PAGE_R_W_ERROR:
         p[1] = 10;
+        if (page_control == 1) { /* Changeable Values */
+            break;
+        }
         p[2] = 0x80; /* Automatic Write Reallocation Enabled */
         if (s->qdev.type == TYPE_ROM) {
             p[3] = 0x20; /* Read Retry Count */