Patchwork [V2] i2c: imx: make bitrate an u32 type

login
register
mail settings
Submitter Wolfram Sang
Date July 9, 2012, 10:28 p.m.
Message ID <1341872910-26687-1-git-send-email-wolfram@the-dreams.de>
Download mbox | patch
Permalink /patch/169974/
State New
Headers show

Comments

Wolfram Sang - July 9, 2012, 10:28 p.m.
sparse found this assignment of u32 to an int. Fix it:

drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)

and also fix the type in platform_data. All current users use values
which fit into the old and new type, so it is a safe change.

Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
Cc: Richard Zhao <richard.zhao@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---

Changes since V1: also change type in platform_data. Thanks to Richard.

 arch/arm/plat-mxc/include/mach/i2c.h |    2 +-
 drivers/i2c/busses/i2c-imx.c         |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Richard Zhao - July 9, 2012, 11:08 p.m.
On Tue, Jul 10, 2012 at 12:28:30AM +0200, Wolfram Sang wrote:
> sparse found this assignment of u32 to an int. Fix it:
> 
> drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)
> 
> and also fix the type in platform_data. All current users use values
> which fit into the old and new type, so it is a safe change.
> 
> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
> Cc: Richard Zhao <richard.zhao@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Richard Zhao <richard.zhao@freescale.com>
> ---
> 
> Changes since V1: also change type in platform_data. Thanks to Richard.
> 
>  arch/arm/plat-mxc/include/mach/i2c.h |    2 +-
>  drivers/i2c/busses/i2c-imx.c         |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/include/mach/i2c.h b/arch/arm/plat-mxc/include/mach/i2c.h
> index 375cdd0..8289d91 100644
> --- a/arch/arm/plat-mxc/include/mach/i2c.h
> +++ b/arch/arm/plat-mxc/include/mach/i2c.h
> @@ -15,7 +15,7 @@
>   *
>   **/
>  struct imxi2c_platform_data {
> -	int bitrate;
> +	u32 bitrate;
>  };
>  
>  #endif /* __ASM_ARCH_I2C_H_ */
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index dd2a083..90460dd 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -471,8 +471,8 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
>  	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
>  	struct pinctrl *pinctrl;
>  	void __iomem *base;
> -	int irq, bitrate;
> -	int ret;
> +	int irq, ret;
> +	u32 bitrate;
>  
>  	dev_dbg(&pdev->dev, "<%s>\n", __func__);
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sascha Hauer - July 10, 2012, 8:42 a.m.
On Tue, Jul 10, 2012 at 12:28:30AM +0200, Wolfram Sang wrote:
> sparse found this assignment of u32 to an int. Fix it:
> 
> drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)
> 
> and also fix the type in platform_data. All current users use values
> which fit into the old and new type, so it is a safe change.
> 
> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
> Cc: Richard Zhao <richard.zhao@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
> 
> Changes since V1: also change type in platform_data. Thanks to Richard.
> 
>  arch/arm/plat-mxc/include/mach/i2c.h |    2 +-
>  drivers/i2c/busses/i2c-imx.c         |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/include/mach/i2c.h b/arch/arm/plat-mxc/include/mach/i2c.h
> index 375cdd0..8289d91 100644
> --- a/arch/arm/plat-mxc/include/mach/i2c.h
> +++ b/arch/arm/plat-mxc/include/mach/i2c.h
> @@ -15,7 +15,7 @@
>   *
>   **/
>  struct imxi2c_platform_data {
> -	int bitrate;
> +	u32 bitrate;
>  };
>  
>  #endif /* __ASM_ARCH_I2C_H_ */
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index dd2a083..90460dd 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -471,8 +471,8 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
>  	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
>  	struct pinctrl *pinctrl;
>  	void __iomem *base;
> -	int irq, bitrate;
> -	int ret;
> +	int irq, ret;
> +	u32 bitrate;
>  
>  	dev_dbg(&pdev->dev, "<%s>\n", __func__);
>  
> -- 
> 1.7.10.4
> 
>

Patch

diff --git a/arch/arm/plat-mxc/include/mach/i2c.h b/arch/arm/plat-mxc/include/mach/i2c.h
index 375cdd0..8289d91 100644
--- a/arch/arm/plat-mxc/include/mach/i2c.h
+++ b/arch/arm/plat-mxc/include/mach/i2c.h
@@ -15,7 +15,7 @@ 
  *
  **/
 struct imxi2c_platform_data {
-	int bitrate;
+	u32 bitrate;
 };
 
 #endif /* __ASM_ARCH_I2C_H_ */
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index dd2a083..90460dd 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -471,8 +471,8 @@  static int __init i2c_imx_probe(struct platform_device *pdev)
 	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
 	struct pinctrl *pinctrl;
 	void __iomem *base;
-	int irq, bitrate;
-	int ret;
+	int irq, ret;
+	u32 bitrate;
 
 	dev_dbg(&pdev->dev, "<%s>\n", __func__);