Patchwork sparc64: remove unused function straddles_64bit_va_hole()

login
register
mail settings
Submitter Kirill Tkhai
Date July 9, 2012, 2:22 p.m.
Message ID <262801341843731@web29e.yandex.ru>
Download mbox | patch
Permalink /patch/169857/
State Accepted
Delegated to: David Miller
Headers show

Comments

Kirill Tkhai - July 9, 2012, 2:22 p.m.
Nobody uses straddles_64bit_va_hole(). Remove it

Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
---
arch/sparc/kernel/sys_sparc_64.c |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 9, 2012, 9:15 p.m.
From: Kirill Tkhai <tkhai@yandex.ru>
Date: Mon, 09 Jul 2012 18:22:11 +0400

> Nobody uses straddles_64bit_va_hole(). Remove it
> 
> Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>

Well, that's a bug, because we have to keep applications from
being to mmap() things into this virtual address range.

I'll look into the GIT history to see how it has erroneously
become unused.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 9, 2012, 9:33 p.m.
From: David Miller <davem@davemloft.net>
Date: Mon, 09 Jul 2012 14:15:51 -0700 (PDT)

> From: Kirill Tkhai <tkhai@yandex.ru>
> Date: Mon, 09 Jul 2012 18:22:11 +0400
> 
>> Nobody uses straddles_64bit_va_hole(). Remove it
>> 
>> Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
> 
> Well, that's a bug, because we have to keep applications from
> being to mmap() things into this virtual address range.
> 
> I'll look into the GIT history to see how it has erroneously
> become unused.

Ok, I see what happened.

When Al viro removed sparc_brk() from this file, it removed the
last user.  And legitimately so.

I'll therefore apply your patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/kernel/sys_sparc_64.c b/arch/sparc/kernel/sys_sparc_64.c
index 3ee51f1..a47c262 100644
--- a/arch/sparc/kernel/sys_sparc_64.c
+++ b/arch/sparc/kernel/sys_sparc_64.c
@@ -66,23 +66,6 @@  static inline int invalid_64bit_range(unsigned long addr, unsigned long len)
 	return 0;
 }
 
-/* Does start,end straddle the VA-space hole?  */
-static inline int straddles_64bit_va_hole(unsigned long start, unsigned long end)
-{
-	unsigned long va_exclude_start, va_exclude_end;
-
-	va_exclude_start = VA_EXCLUDE_START;
-	va_exclude_end   = VA_EXCLUDE_END;
-
-	if (likely(start < va_exclude_start && end < va_exclude_start))
-		return 0;
-
-	if (likely(start >= va_exclude_end && end >= va_exclude_end))
-		return 0;
-
-	return 1;
-}
-
 /* These functions differ from the default implementations in
  * mm/mmap.c in two ways:
  *