Patchwork Add nand platform on imx27 devicetree

login
register
mail settings
Submitter trem
Date July 8, 2012, 4:29 p.m.
Message ID <1341764963-11402-1-git-send-email-tremyfr@yahoo.fr>
Download mbox | patch
Permalink /patch/169651/
State New
Headers show

Comments

trem - July 8, 2012, 4:29 p.m.
Signed-off-by: Philippe Reynes <tremyfr@yahoo.fr>
---
 arch/arm/mach-imx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Fabio Estevam - July 8, 2012, 4:57 p.m.
Hi Philippe,

On Sun, Jul 8, 2012 at 1:29 PM, Philippe Reynes <tremyfr@yahoo.fr> wrote:
> Signed-off-by: Philippe Reynes <tremyfr@yahoo.fr>
> ---
>  arch/arm/mach-imx/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index eff4db5..565422b 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -381,6 +381,7 @@ config MACH_IMX27_DT
>         bool "Support i.MX27 platforms from device tree"
>         select SOC_IMX27
>         select USE_OF
> +       select IMX_HAVE_PLATFORM_MXC_NAND

Bu doing this you end up selecting unnecessary code for dt.

I proposed a fix for this already:
http://patchwork.ozlabs.org/patch/168645/

Regards,

Fabio Estevam
Uwe Kleine-K├Ânig - July 8, 2012, 7:52 p.m.
Hi,

On Sun, Jul 08, 2012 at 01:57:37PM -0300, Fabio Estevam wrote:
> On Sun, Jul 8, 2012 at 1:29 PM, Philippe Reynes <tremyfr@yahoo.fr> wrote:
> > Signed-off-by: Philippe Reynes <tremyfr@yahoo.fr>
> > ---
> >  arch/arm/mach-imx/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index eff4db5..565422b 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -381,6 +381,7 @@ config MACH_IMX27_DT
> >         bool "Support i.MX27 platforms from device tree"
> >         select SOC_IMX27
> >         select USE_OF
> > +       select IMX_HAVE_PLATFORM_MXC_NAND
> 
> Bu doing this you end up selecting unnecessary code for dt.
> 
> I proposed a fix for this already:
> http://patchwork.ozlabs.org/patch/168645/
I only know understood your explaination why you don't want this patch
instead. So ok, I prefer your patch, too.

Best regards
Uwe

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index eff4db5..565422b 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -381,6 +381,7 @@  config MACH_IMX27_DT
 	bool "Support i.MX27 platforms from device tree"
 	select SOC_IMX27
 	select USE_OF
+	select IMX_HAVE_PLATFORM_MXC_NAND
 	help
 	  Include support for Freescale i.MX27 based platforms
 	  using the device tree for discovery