Patchwork [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin

login
register
mail settings
Submitter Steven Bosscher
Date July 7, 2012, 2:48 p.m.
Message ID <CABu31nMzpoXkgLc=GE0MmVLt0=jxUn=RY3Zmi_sXx8_EZoUjXw@mail.gmail.com>
Download mbox | patch
Permalink /patch/169598/
State New
Headers show

Comments

Steven Bosscher - July 7, 2012, 2:48 p.m.
Hello,


PR26840 was fixed long ago so this work-around shouldn't be necessary anymore:

        $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<


Request for testing because I have no access to a Darwin machine.

Thanks,

Ciao!
Steven
H.J. Lu - July 7, 2012, 3:06 p.m.
On Sat, Jul 7, 2012 at 7:48 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
>
> PR26840 was fixed long ago so this work-around shouldn't be necessary anymore:
>
> Index: ../libgcc/config/t-darwin
> ===================================================================
> --- ../libgcc/config/t-darwin   (revision 189348)
> +++ ../libgcc/config/t-darwin   (working copy)
> @@ -1,7 +1,5 @@
> -# Pass -fno-tree-dominator-opts to work around bug 26840.
>  crt3.o: $(srcdir)/config/darwin-crt3.c
> -       $(crt_compile) \
> -         -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
> +       $(crt_compile) -fno-tree-dominator-opts
> $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
>

Are you sure this the right patch? -fno-tree-dominator-opts is still here.

Patch

Index: ../libgcc/config/t-darwin
===================================================================
--- ../libgcc/config/t-darwin   (revision 189348)
+++ ../libgcc/config/t-darwin   (working copy)
@@ -1,7 +1,5 @@ 
-# Pass -fno-tree-dominator-opts to work around bug 26840.
 crt3.o: $(srcdir)/config/darwin-crt3.c
-       $(crt_compile) \
-         -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
+       $(crt_compile) -fno-tree-dominator-opts
$(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<

 crttms.o: $(srcdir)/config/darwin-crt-tm.c