From patchwork Fri Jul 6 17:47:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 169511 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 95FDA2C01D3 for ; Sat, 7 Jul 2012 03:55:07 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SnCfT-0001s8-Vf; Fri, 06 Jul 2012 17:50:12 +0000 Received: from [2002:4e20:1eda::1] (helo=caramon.arm.linux.org.uk) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SnCfL-0001re-FI for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2012 17:50:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ZWqZPZ0Y8C9q7+Ni73NRvgCiib5p8ySMcchotr7xv2U=; b=joVCLbMI6Vl7Ao/BBhgZlSrKK8h8V57fG+iZ0fMyxZngY8fLBUTeRKK5qNcYzqXIR+ngYaHcXQmkYySgTg6ewBPVEBuHvdoen/0GjJu/+eSy1pJ4Mup7NGvePdm+tLwCwlyh2nsA+2qLkJSPiid8I3v70XBKsV2Sgtzhb+la8x8=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:45151) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1SnCcQ-0001iI-BO; Fri, 06 Jul 2012 18:47:02 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1SnCcP-0007Vy-2n; Fri, 06 Jul 2012 18:47:01 +0100 Date: Fri, 6 Jul 2012 18:47:00 +0100 From: Russell King - ARM Linux To: Javier Martin Subject: Re: [PATCH 3/3] Visstrim M10: Add support for Coda. Message-ID: <20120706174700.GD31508@n2100.arm.linux.org.uk> References: <1341579471-25208-1-git-send-email-javier.martin@vista-silicon.com> <1341579471-25208-4-git-send-email-javier.martin@vista-silicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1341579471-25208-4-git-send-email-javier.martin@vista-silicon.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: fabio.estevam@freescale.com, sakari.ailus@maxwell.research.nokia.com, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org, mchehab@infradead.org, richard.zhu@linaro.org, kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com, kernel@pengutronix.de, p.zabel@pengutronix.de, shawn.guo@linaro.org, arnaud.patard@rtp-net.org, linux-media@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Fri, Jul 06, 2012 at 02:57:51PM +0200, Javier Martin wrote: > Support the codadx6 that is included in > the i.MX27 SoC. > --- > arch/arm/mach-imx/mach-imx27_visstrim_m10.c | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c > index f76edb9..bee2714 100644 > --- a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c > +++ b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c > @@ -232,10 +232,10 @@ static void __init visstrim_camera_init(void) > static void __init visstrim_reserve(void) > { > /* reserve 4 MiB for mx2-camera */ > - mx2_camera_base = memblock_alloc(MX2_CAMERA_BUF_SIZE, > + mx2_camera_base = memblock_alloc(2 * MX2_CAMERA_BUF_SIZE, > MX2_CAMERA_BUF_SIZE); > - memblock_free(mx2_camera_base, MX2_CAMERA_BUF_SIZE); > - memblock_remove(mx2_camera_base, MX2_CAMERA_BUF_SIZE); > + memblock_free(mx2_camera_base, 2 * MX2_CAMERA_BUF_SIZE); > + memblock_remove(mx2_camera_base, 2 * MX2_CAMERA_BUF_SIZE); NAK. If you're going to do this please move it to the right API: arch/arm/mach-imx/mach-imx27_visstrim_m10.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index f7b074f..c27058e 100644 --- a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c +++ b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c @@ -32,12 +32,12 @@ #include #include #include -#include #include #include #include #include #include +#include #include #include @@ -193,10 +193,8 @@ static void __init visstrim_camera_init(void) static void __init visstrim_reserve(void) { /* reserve 4 MiB for mx2-camera */ - mx2_camera_base = memblock_alloc(MX2_CAMERA_BUF_SIZE, + mx2_camera_base = memblock_steal(MX2_CAMERA_BUF_SIZE, MX2_CAMERA_BUF_SIZE); - memblock_free(mx2_camera_base, MX2_CAMERA_BUF_SIZE); - memblock_remove(mx2_camera_base, MX2_CAMERA_BUF_SIZE); } /* GPIOs used as events for applications */