From patchwork Fri Jul 6 16:33:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 169491 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f184.google.com (mail-gh0-f184.google.com [209.85.160.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B5D9E2C01FA for ; Sat, 7 Jul 2012 02:34:03 +1000 (EST) Received: by ghbf19 with SMTP id f19sf9923906ghb.11 for ; Fri, 06 Jul 2012 09:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=RT4OIMoZT65AOuZ7li8/HXk4ewQWEk3MnSDbZ8eb6Kc=; b=1u/E/rmDJ8Y7JrOhsRT16gh1GZAuIJ9HLm5+aMhBchUbXgE4unwx2agLc5jQVVPHVr ZK9KhK1aerv1KNjzTkroQW7jfWf7oWV33CU4xJx9OPrKqmjMrJ53C/GQeavNAdbE4MGI 7jdSEkXxa0grrG2akKe+XFAXsL91mtQDXTfUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:x-gm-message-state:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=RT4OIMoZT65AOuZ7li8/HXk4ewQWEk3MnSDbZ8eb6Kc=; b=fvgYkVn8fg7jZj1qpDrhIaMvpt0Rq1tevTSQOWBAIUhd64wm5LoKgtgbLp9DlI0XKF H9nHDLRfpBnegEZUWul8dCtRMp6FZpSLAaOeoX8/yXkmfr20cAfWB1y15WnuC76ZT1qO R2Kx7XkJ48vOBykVYVHWoheoYwPYxM5Bm5oejzdooBp0i40RjN+PgzTLzCA/8kp/gE11 g6VwHBu5MCz8jLNAU353dXKjuqgNXz5Ye5xv8aqEGoIl4W67aFAqM6R3OcUqpGT4/gDL yUIB4f72NaS83NJTPzntsVR7JQ7rp4lw58phxIDVhXaT/LATiixTtyjrNUteYfm2UyH1 +Bew== Received: by 10.50.149.234 with SMTP id ud10mr749148igb.4.1341592441075; Fri, 06 Jul 2012 09:34:01 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.11.232 with SMTP id t8ls1373671igb.2.canary; Fri, 06 Jul 2012 09:34:00 -0700 (PDT) Received: by 10.68.241.162 with SMTP id wj2mr13627563pbc.2.1341592440414; Fri, 06 Jul 2012 09:34:00 -0700 (PDT) Received: by 10.68.241.162 with SMTP id wj2mr13627562pbc.2.1341592440405; Fri, 06 Jul 2012 09:34:00 -0700 (PDT) Received: from na3sys009aog128.obsmtp.com ([74.125.149.141]) by gmr-mx.google.com with SMTP id gg7si313902pbc.0.2012.07.06.09.34.00 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Jul 2012 09:34:00 -0700 (PDT) Received-SPF: pass (google.com: domain of khilman@ti.com designates 74.125.149.141 as permitted sender) client-ip=74.125.149.141; Received: from mail-pb0-f49.google.com ([209.85.160.49]) (using TLSv1) by na3sys009aob128.postini.com ([74.125.148.12]) with SMTP ID DSNKT/cTdy9E1mgRc+AaV/q8tEpeK/INn95E@postini.com; Fri, 06 Jul 2012 09:34:00 PDT Received: by pbbrq13 with SMTP id rq13so15719979pbb.8 for ; Fri, 06 Jul 2012 09:33:56 -0700 (PDT) Received: by 10.68.220.231 with SMTP id pz7mr38053512pbc.110.1341592436376; Fri, 06 Jul 2012 09:33:56 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id jv6sm22153580pbc.40.2012.07.06.09.33.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Jul 2012 09:33:55 -0700 (PDT) From: Kevin Hilman To: Andrew Morton , rtc-linux@googlegroups.com, Alessandro Zummo Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT Date: Fri, 6 Jul 2012 09:33:54 -0700 Message-Id: <1341592434-4207-1-git-send-email-khilman@ti.com> X-Mailer: git-send-email 1.7.9.2 X-Gm-Message-State: ALoCoQksC9Y7+ONX8T2QJAy9xZ8rXPXNjEuDdHb3goNFg5R9VLQeKBcU7KRMsKkVVM+xTRB6oQTn X-Original-Sender: khilman@ti.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of khilman@ti.com designates 74.125.149.141 as permitted sender) smtp.mail=khilman@ti.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Requesting a threaded interrupt without a primary handler and without IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject bogus threaded irq requests), these requests are rejected. This causes ->probe() to fail, and the RTC driver not to be availble. To fix, add IRQF_ONESHOT to the IRQ flags. Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to wake from system suspend multiple times. Signed-off-by: Kevin Hilman --- Resending to broader audience and including Andrew. Since, I understand that drivers/rtc is somewhat orphaned, Andrew, can you queue this fix for v3.5. Thanks. drivers/rtc/rtc-twl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 258abea..c5d06fe 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c @@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev) } ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt, - IRQF_TRIGGER_RISING, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, dev_name(&rtc->dev), rtc); if (ret < 0) { dev_err(&pdev->dev, "IRQ is not free.\n");