From patchwork Fri Jul 6 11:27:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 169464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id AC8432C0040 for ; Fri, 6 Jul 2012 22:22:15 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1342182137; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:From:To:Cc:Subject:References:Date: In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=1h9v5mKDBgkrZLmbFbTF 9VNfSfU=; b=owaTgazDUlGFTeYdvVtJ7dMPki2XHDt+2oqFfE70lpXx2OcuED3L d6uRn+U7LcMWWnFS1fPlBSvLrmcMABiRPInFd1SP+fuvY66s+tNaCoGiteupzq50 g2WNWR/yC17QaeeV4kYalmeEybcATTqHSYpULsfAooQqKgjzgJZq/B0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=dWrBp2wiOx/gikKiou4E60glR7te+24dnhFEClggrrcAO231Wf9BDjjQT/ZaCH meo39WRq7FmfsdEg8ylPCocPy47al8IeHmUj+QoaFSoUhEPfzVlYiJ0TFM/ABkKD tjxFuGRevp20qcRO4pj+Z7fWaXICoHYKkEFfCkOCAcCnM=; Received: (qmail 19714 invoked by alias); 6 Jul 2012 12:22:09 -0000 Received: (qmail 19695 invoked by uid 22791); 6 Jul 2012 12:22:08 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Jul 2012 12:21:51 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q66CLoJC001765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Jul 2012 08:21:50 -0400 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q66CLlTL031607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Jul 2012 08:21:50 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.5/8.14.5) with ESMTP id q66BRnFQ016045; Fri, 6 Jul 2012 08:27:50 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q66BRmLK019214; Fri, 6 Jul 2012 08:27:48 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id q66BRlB5019212; Fri, 6 Jul 2012 08:27:47 -0300 From: Alexandre Oliva To: Uros Bizjak Cc: Richard Guenther , "H.J. Lu" , Richard Henderson , Jakub Jelinek , gcc-patches@gcc.gnu.org Subject: Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs References: <20120523101349.GN16117@tyan-ft48-01.lab.bos.redhat.com> <4FD7A9BE.4080405@redhat.com> Date: Fri, 06 Jul 2012 08:27:47 -0300 In-Reply-To: (Alexandre Oliva's message of "Thu, 21 Jun 2012 21:58:41 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Jun 21, 2012, Alexandre Oliva wrote: > for gcc/ChangeLog > from Alexandre Oliva > PR debug/53671 > PR debug/49888 > * alias.c (memrefs_conflict_p): Improve handling of AND for > alignment. There was a thinko in this patch. We can't move the offset by more than we adjust the size, otherwise we fail to cover part of the required range, as reported in PR rtl-optimization/53827. This obvious patch fixes it. Regstrapped on x86_64- and i686-linux-gnu. Uros confirmed it fixed the bootstrap problem on alpha-linux-gnu. I'm checking this in. for gcc/ChangeLog from Alexandre Oilva PR rtl-optimization/53827 PR debug/53671 PR debug/49888 * alias.c (memrefs_conflict_p): Adjust offset and size by the same amount for alignment ANDs. Index: gcc/alias.c =================================================================== --- gcc/alias.c.orig 2012-07-02 09:04:06.193137799 -0300 +++ gcc/alias.c 2012-07-02 09:04:08.000000000 -0300 @@ -2107,7 +2107,7 @@ memrefs_conflict_p (int xsize, rtx x, in if (xsize > 0 && sc < 0 && -uc == (uc & -uc)) { xsize -= sc + 1; - c -= sc; + c -= sc + 1; return memrefs_conflict_p (xsize, canon_rtx (XEXP (x, 0)), ysize, y, c); } @@ -2119,7 +2119,7 @@ memrefs_conflict_p (int xsize, rtx x, in if (ysize > 0 && sc < 0 && -uc == (uc & -uc)) { ysize -= sc + 1; - c += sc; + c += sc + 1; return memrefs_conflict_p (xsize, x, ysize, canon_rtx (XEXP (y, 0)), c); }