From patchwork Fri Jul 6 10:09:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 169404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B3BD92C00E7 for ; Fri, 6 Jul 2012 20:09:42 +1000 (EST) Received: from localhost ([::1]:58714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn5To-0004Wl-Ab for incoming@patchwork.ozlabs.org; Fri, 06 Jul 2012 06:09:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn5TL-0003Xc-7l for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn5TC-0001PP-Mv for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn5TC-0001Oj-FD for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:02 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q66A908n030205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Jul 2012 06:09:01 -0400 Received: from shalem.localdomain.com (vpn1-4-112.ams2.redhat.com [10.36.4.112]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q66A8uCm001768; Fri, 6 Jul 2012 06:08:59 -0400 From: Hans de Goede To: Gerd Hoffmann Date: Fri, 6 Jul 2012 12:09:33 +0200 Message-Id: <1341569373-9478-3-git-send-email-hdegoede@redhat.com> In-Reply-To: <1341569373-9478-1-git-send-email-hdegoede@redhat.com> References: <1341569373-9478-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH 2/2] usb-ehci: Fix an assert whenever isoc transfers are used X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index e759c99..eaa3ddd 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2300,6 +2300,7 @@ static int usb_ehci_initfn(PCIDevice *dev) s->frame_timer = qemu_new_timer_ns(vm_clock, ehci_frame_timer, s); QTAILQ_INIT(&s->aqueues); QTAILQ_INIT(&s->pqueues); + usb_packet_init(&s->ipacket); qemu_register_reset(ehci_reset, s);