Patchwork [2/2] usb-ehci: Fix an assert whenever isoc transfers are used

login
register
mail settings
Submitter Hans de Goede
Date July 6, 2012, 10:09 a.m.
Message ID <1341569373-9478-3-git-send-email-hdegoede@redhat.com>
Download mbox | patch
Permalink /patch/169404/
State New
Headers show

Comments

Hans de Goede - July 6, 2012, 10:09 a.m.
hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket
it uses for isoc transfers, triggering an assert (taking the entire vm down)
in usb_packet_setup as soon as any isoc transfers are done by a high speed
USB device.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/hcd-ehci.c |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index e759c99..eaa3ddd 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2300,6 +2300,7 @@  static int usb_ehci_initfn(PCIDevice *dev)
     s->frame_timer = qemu_new_timer_ns(vm_clock, ehci_frame_timer, s);
     QTAILQ_INIT(&s->aqueues);
     QTAILQ_INIT(&s->pqueues);
+    usb_packet_init(&s->ipacket);
 
     qemu_register_reset(ehci_reset, s);