From patchwork Fri Jul 6 08:04:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 169362 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 654042C007E for ; Fri, 6 Jul 2012 18:08:52 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sn3Wu-0005aO-WB; Fri, 06 Jul 2012 08:04:45 +0000 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16] helo=va3outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Sn3WR-0005aA-Lz for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2012 08:04:20 +0000 Received: from mail173-va3-R.bigfish.com (10.7.14.246) by VA3EHSOBE002.bigfish.com (10.7.40.22) with Microsoft SMTP Server id 14.1.225.23; Fri, 6 Jul 2012 08:02:04 +0000 Received: from mail173-va3 (localhost [127.0.0.1]) by mail173-va3-R.bigfish.com (Postfix) with ESMTP id 62E89160154; Fri, 6 Jul 2012 08:02:04 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -4 X-BigFish: VS-4(zz98dIc89bh936eI1432I4015Izz1202hzz8275dhz2dh87h2a8h668h839hd25he96hf0ah107ah) X-FB-DOMAIN-IP-MATCH: fail Received: from mail173-va3 (localhost.localdomain [127.0.0.1]) by mail173-va3 (MessageSwitch) id 1341561721995005_16914; Fri, 6 Jul 2012 08:02:01 +0000 (UTC) Received: from VA3EHSMHS019.bigfish.com (unknown [10.7.14.235]) by mail173-va3.bigfish.com (Postfix) with ESMTP id E467B3E0043; Fri, 6 Jul 2012 08:02:01 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS019.bigfish.com (10.7.99.29) with Microsoft SMTP Server (TLS) id 14.1.225.23; Fri, 6 Jul 2012 08:02:00 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server (TLS) id 14.2.298.5; Fri, 6 Jul 2012 03:04:05 -0500 Received: from S2101-09.ap.freescale.net ([10.192.185.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id q66841fr023071; Fri, 6 Jul 2012 01:04:02 -0700 Date: Fri, 6 Jul 2012 16:04:09 +0800 From: Shawn Guo To: Arnd Bergmann , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2] ARM: imx: select USE_OF Message-ID: <20120706080407.GB22133@S2101-09.ap.freescale.net> References: <20120706071247.GC30009@pengutronix.de> <1341560840-30400-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1341560840-30400-1-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [216.32.180.16 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Sascha Hauer , Rob Herring , Grant Likely , kernel@pengutronix.de, Dong Aisheng , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Fri, Jul 06, 2012 at 09:47:20AM +0200, Uwe Kleine-König wrote: > Commit > > 544496a (ARM: imx: move irq_domain_add_legacy call into avic driver) > > introduced unconditional calls to irq_find_mapping and > irq_domain_add_legacy, but it's still possible to have a .config without > CONFIG_IRQ_DOMAIN=y resulting in > > CC arch/arm/plat-mxc/avic.o > arch/arm/plat-mxc/avic.c: In function 'avic_handle_irq': > arch/arm/plat-mxc/avic.c:172: error: implicit declaration of function 'irq_find_mapping' > arch/arm/plat-mxc/avic.c: In function 'mxc_init_irq': > arch/arm/plat-mxc/avic.c:207: error: implicit declaration of function 'irq_domain_add_legacy' > arch/arm/plat-mxc/avic.c:208: error: 'irq_domain_simple_ops' undeclared (first use in this function) > arch/arm/plat-mxc/avic.c:208: error: (Each undeclared identifier is reported only once > arch/arm/plat-mxc/avic.c:208: error: for each function it appears in.) > arch/arm/plat-mxc/avic.c:208: warning: assignment makes pointer from integer without a cast > make[3]: *** [arch/arm/plat-mxc/avic.o] Error 1 > make[2]: *** [arch/arm/plat-mxc/avic.o] Error 2 > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2 > > While selecting CONFIG_IRQ_DOMAIN would be enough, USE_OF is the future > and implies CONFIG_IRQ_DOMAIN. So select USE_OF for ARCH_MXC and drop > other explicit selects that are superflous now. > > Signed-off-by: Uwe Kleine-König Applied on top of imx/sparse-irq branch. Thanks, Uwe. Arnd, One more fix, sorry. Can you please pull it? Regards, Shawn The following changes since commit 6684294d27abb24e61916871c4ecfdaccc14eb03: ARM: imx: Fix build error due to missing irqs.h include (2012-07-04 11:19:40 +0800) are available in the git repository at: git://git.linaro.org/people/shawnguo/linux-2.6.git imx/sparse-irq Uwe Kleine-König (1): ARM: imx: select USE_OF arch/arm/Kconfig | 1 + arch/arm/mach-imx/Kconfig | 4 ---- 2 files changed, 1 insertions(+), 4 deletions(-)