Patchwork [1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c

login
register
mail settings
Submitter Wang Sheng-Hui
Date July 6, 2012, 6:26 a.m.
Message ID <4FF68511.9050207@gmail.com>
Download mbox | patch
Permalink /patch/169334/
State New
Headers show

Comments

Wang Sheng-Hui - July 6, 2012, 6:26 a.m.
The left and right extents merge is done by
ext4_ext_try_to_merge. No specific left/right
fun calls any more.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 fs/ext4/extents.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
Zheng Liu - July 7, 2012, 3:15 p.m.
Hi Sheng-Hui,

It seems that there has a patch to fix it.
http://www.spinics.net/lists/linux-ext4/msg32611.html

Regards,
Zheng

On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui <shhuiw@gmail.com> wrote:
> The left and right extents merge is done by
> ext4_ext_try_to_merge. No specific left/right
> fun calls any more.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  fs/ext4/extents.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 5207b7b..6c2a37d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1891,12 +1891,10 @@ has_space:
>         nearex->ee_len = newext->ee_len;
>
>  merge:
> -       /* try to merge extents to the right */
> +       /* try to merge extents to the neighbours */
>         if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>                 ext4_ext_try_to_merge(inode, path, nearex);
>
> -       /* try to merge extents to the left */
> -
>         /* time to correct all indexes above */
>         err = ext4_ext_correct_indexes(handle, inode, path);
>         if (err)
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wang Sheng-Hui - July 8, 2012, 10:38 a.m.
On 2012年07月07日 23:15, Zheng Liu wrote:
> Hi Sheng-Hui,
> 
> It seems that there has a patch to fix it.
> http://www.spinics.net/lists/linux-ext4/msg32611.html
> 
> Regards,
> Zheng

Got it. 

I didn't track the patch list. Just checked the git tree.

Thanks,

> 
> On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui <shhuiw@gmail.com> wrote:
>> The left and right extents merge is done by
>> ext4_ext_try_to_merge. No specific left/right
>> fun calls any more.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>> ---
>>  fs/ext4/extents.c |    4 +---
>>  1 files changed, 1 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
>> index 5207b7b..6c2a37d 100644
>> --- a/fs/ext4/extents.c
>> +++ b/fs/ext4/extents.c
>> @@ -1891,12 +1891,10 @@ has_space:
>>         nearex->ee_len = newext->ee_len;
>>
>>  merge:
>> -       /* try to merge extents to the right */
>> +       /* try to merge extents to the neighbours */
>>         if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>>                 ext4_ext_try_to_merge(inode, path, nearex);
>>
>> -       /* try to merge extents to the left */
>> -
>>         /* time to correct all indexes above */
>>         err = ext4_ext_correct_indexes(handle, inode, path);
>>         if (err)
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5207b7b..6c2a37d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1891,12 +1891,10 @@  has_space:
 	nearex->ee_len = newext->ee_len;
 
 merge:
-	/* try to merge extents to the right */
+	/* try to merge extents to the neighbours */
 	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
 		ext4_ext_try_to_merge(inode, path, nearex);
 
-	/* try to merge extents to the left */
-
 	/* time to correct all indexes above */
 	err = ext4_ext_correct_indexes(handle, inode, path);
 	if (err)