Patchwork [1/3] target-i386: Remove unused macros

login
register
mail settings
Submitter Peter Maydell
Date July 5, 2012, 9:28 p.m.
Message ID <1341523740-22711-2-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/169275/
State New
Headers show

Comments

Peter Maydell - July 5, 2012, 9:28 p.m.
Commit 11f8cdb removed all the uses of the X86_64_ONLY
macro. The BUGGY_64() macro has been unused for a long time:
it originally marked some ops which couldn't be enabled
because of issues with the pre-TCG code generation scheme.
Remove the now-unnecessary definitions of both macros.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-i386/translate.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
Stefan Weil - July 6, 2012, 5:31 a.m.
Am 05.07.2012 23:28, schrieb Peter Maydell:
> Commit 11f8cdb removed all the uses of the X86_64_ONLY
> macro. The BUGGY_64() macro has been unused for a long time:
> it originally marked some ops which couldn't be enabled
> because of issues with the pre-TCG code generation scheme.
> Remove the now-unnecessary definitions of both macros.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target-i386/translate.c |    6 ------
>   1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index a00a6a1..8d696ea 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -38,17 +38,11 @@
>   #define PREFIX_ADR    0x10
>   
>   #ifdef TARGET_X86_64
> -#define X86_64_ONLY(x) x
>   #define X86_64_DEF(...)  __VA_ARGS__
>   #define CODE64(s) ((s)->code64)
>   #define REX_X(s) ((s)->rex_x)
>   #define REX_B(s) ((s)->rex_b)
> -/* XXX: gcc generates push/pop in some opcodes, so we cannot use them */
> -#if 1
> -#define BUGGY_64(x) NULL
> -#endif
>   #else
> -#define X86_64_ONLY(x) NULL
>   #define X86_64_DEF(...)
>   #define CODE64(s) 0
>   #define REX_X(s) 0

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Patch

diff --git a/target-i386/translate.c b/target-i386/translate.c
index a00a6a1..8d696ea 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -38,17 +38,11 @@ 
 #define PREFIX_ADR    0x10
 
 #ifdef TARGET_X86_64
-#define X86_64_ONLY(x) x
 #define X86_64_DEF(...)  __VA_ARGS__
 #define CODE64(s) ((s)->code64)
 #define REX_X(s) ((s)->rex_x)
 #define REX_B(s) ((s)->rex_b)
-/* XXX: gcc generates push/pop in some opcodes, so we cannot use them */
-#if 1
-#define BUGGY_64(x) NULL
-#endif
 #else
-#define X86_64_ONLY(x) NULL
 #define X86_64_DEF(...)
 #define CODE64(s) 0
 #define REX_X(s) 0