| Message ID | 1341520399-5889-1-git-send-email-timur@freescale.com |
|---|---|
| State | Accepted |
| Commit | 6e5b9ac097689e96d53f638842823fb1d1bf4223 |
| Delegated to: | Joe Hershberger |
| Headers | show |
Hi Timur Tabi, On Thu, Jul 5, 2012 at 3:33 PM, Timur Tabi <timur@freescale.com> wrote: > phy_startup() calls the PHY driver's startup function, but it ignores the > return code from that function, and so it never returns any failures. > > Signed-off-by: Timur Tabi <timur@freescale.com> > --- Applied to next, thanks. -Joe
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 7d327f7..baef60f 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -723,10 +723,13 @@ struct phy_device *phy_connect(struct mii_dev *bus, int addr, return phydev; } +/* + * Start the PHY. Returns 0 on success, or a negative error code. + */ int phy_startup(struct phy_device *phydev) { if (phydev->drv->startup) - phydev->drv->startup(phydev); + return phydev->drv->startup(phydev); return 0; }
phy_startup() calls the PHY driver's startup function, but it ignores the return code from that function, and so it never returns any failures. Signed-off-by: Timur Tabi <timur@freescale.com> --- drivers/net/phy/phy.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)