Patchwork Move Graphite from using PPL over to ISL

login
register
mail settings
Submitter Richard Guenther
Date July 4, 2012, 10:59 a.m.
Message ID <alpine.LNX.2.00.1207041255000.17233@jbgna.fhfr.qr>
Download mbox | patch
Permalink /patch/168949/
State New
Headers show

Comments

Richard Guenther - July 4, 2012, 10:59 a.m.
On Wed, 4 Jul 2012, Tristan Gingold wrote:

> 
> On Jul 4, 2012, at 12:32 PM, Richard Guenther wrote:
> 
> > On Wed, 4 Jul 2012, Tristan Gingold wrote:
> > 
> >> 
> >> On Jul 4, 2012, at 10:58 AM, Richard Guenther wrote:
> >> 
> >>> On Wed, 4 Jul 2012, Tristan Gingold wrote:
> >>> 
> >>>> 
> >>>> On Jul 2, 2012, at 1:43 PM, Richard Guenther wrote:
> >>>> 
> >>>>> On Thu, 28 Jun 2012, Diego Novillo wrote:
> >>>>> 
> >>>>>> On 12-06-27 11:06 , Richard Guenther wrote:
> >>>>>> 
> >>>>>>> 2012-06-27  Richard Guenther  <rguenther@suse.de>
> >>>>>>> 	Michael Matz  <matz@suse.de>
> >>>>>>> 	Tobias Grosser <tobias@grosser.es>
> >>>>>>> 	Sebastian Pop <sebpop@gmail.com>
> >>>>>>> 
> >>>>>>> 	config/
> >>>>>>> 	* cloog.m4: Set up to work against ISL only.
> >>>>>>> 	* isl.m4: New file.
> >>>> 
> >>>> Shouldn't ENABLE_IS_CHECK be automatically set to no when building a cross canadian ?
> >>> 
> >>> Probably yes, as it is a runtime test.  Thus at any time when host != 
> >>> build.  Care to post a patch?  You probably know best what the canonical
> >>> way to check this is.
> >> 
> >> Something like that ?
> >> 
> >> Tested by building a cross and a canadian for ia64-hp-openvms.
> > 
> > Seems to be an incremental patch ontop of the real patch?
> 
> No, what does make you think so ?
> 
> That's an incremental patch on top of many VMS specific unrelated patches, but this is the real patch: building a cross compiler fails without it.

Well,

-       [gcc_cv_isl=no])])
+       [gcc_cv_isl=no],
+       [gcc_cv_isl=yes])])
 
     CFLAGS=$_isl_saved_CFLAGS
     LDFLAGS=$_isl_saved_LDFLAGS

Does not apply for me - there seems to be lines missing.  I guess
the 2nd hunk is for

    AC_CACHE_CHECK([for version $1.$2 of ISL],
      [gcc_cv_isl],
      [AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2)],
        [gcc_cv_isl=yes],
        [gcc_cv_isl=no])])

    CFLAGS=$_isl_saved_CFLAGS

?  Then the patch is ok.

Thanks,
Richard.

Patch

diff --git a/config/isl.m4 b/config/isl.m4
index 152d422..831ac26 100644
--- a/config/isl.m4
+++ b/config/isl.m4
@@ -103,7 +103,7 @@  AC_DEFUN([ISL_REQUESTED],
 
 # _ISL_CHECK_CT_PROG(MAJOR, MINOR)
 # --------------------------------------------
-# Helper for verifying CLooG's compile time version.
+# Helper for verifying ISL compile time version.
 m4_define([_ISL_CHECK_CT_PROG],[AC_LANG_PROGRAM(
   [#include <isl/version.h>
        [gcc_cv_isl=yes],