Patchwork ARM: imx: Fix build error due to missing irqs.h include

login
register
mail settings
Submitter Shawn Guo
Date July 4, 2012, 3:30 a.m.
Message ID <20120704033018.GA1862@S2100-06.ap.freescale.net>
Download mbox
Permalink /patch/168881/
State New
Headers show

Pull-request

git://git.linaro.org/people/shawnguo/linux-2.6.git imx/sparse-irq

Comments

Shawn Guo - July 4, 2012, 3:30 a.m.
Dammit.  I forgot testing imx_v4_v5_defconfig again with the last FIQ
change.  Thanks, Fabio.

Arnd,

I just updated the branch imx/sparse-irq with this fix applied.  Can
you please pull it?

Regards,
Shawn

The following changes since commit 8842a9e2869cae14bbb8184004a42fc3070587fb:

  ARM: imx: enable SPARSE_IRQ for imx platform (2012-07-01 21:59:20 +0800)

are available in the git repository at:
  git://git.linaro.org/people/shawnguo/linux-2.6.git imx/sparse-irq

Fabio Estevam (1):
      ARM: imx: Fix build error due to missing irqs.h include

 arch/arm/plat-mxc/avic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


On Tue, Jul 03, 2012 at 10:25:44PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> commit bc8966 (ARM: fiq: change FIQ_START to a variable) introduced the 
> following build error for imx_v4_v5_defconfig:
> 
> arch/arm/plat-mxc/avic.c:220:11: error: 'FIQ_START' undeclared (first use in this function)
> 
> Include the missing header file to fix it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/plat-mxc/avic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/avic.c b/arch/arm/plat-mxc/avic.c
> index f3d671f..cbd55c3 100644
> --- a/arch/arm/plat-mxc/avic.c
> +++ b/arch/arm/plat-mxc/avic.c
> @@ -26,6 +26,7 @@
>  #include <asm/mach/irq.h>
>  #include <asm/exception.h>
>  #include <mach/hardware.h>
> +#include <mach/irqs.h>
>  
>  #include "irq-common.h"
>  
> -- 
> 1.7.1
>
Arnd Bergmann - July 4, 2012, 8:44 a.m.
On Wednesday 04 July 2012, Shawn Guo wrote:
> 
> Dammit.  I forgot testing imx_v4_v5_defconfig again with the last FIQ
> change.  Thanks, Fabio.
> 
> Arnd,
> 
> I just updated the branch imx/sparse-irq with this fix applied.  Can
> you please pull it?

In the train at the moment without internet access, so I just applied
the patch and added your S-o-b, on top of the next/irq branch.

	Arnd
Russell King - ARM Linux - July 4, 2012, 9:53 a.m.
On Wed, Jul 04, 2012 at 11:30:22AM +0800, Shawn Guo wrote:
> Dammit.  I forgot testing imx_v4_v5_defconfig again with the last FIQ
> change.  Thanks, Fabio.

So, this begs the question - which configs have you tested this series with?
Shawn Guo - July 4, 2012, 1:25 p.m.
On Wed, Jul 04, 2012 at 10:53:02AM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 04, 2012 at 11:30:22AM +0800, Shawn Guo wrote:
> > Dammit.  I forgot testing imx_v4_v5_defconfig again with the last FIQ
> > change.  Thanks, Fabio.
> 
> So, this begs the question - which configs have you tested this series with?

For the patch changing FIQ_START to variable, I tested the following
defconfigs.

rpc_defconfig
s3c2410_defconfig
imx_v6_v7_defconfig

As avic.c is built with imx_v6_v7_defconfig as well, I thought it's
been covered there.  But it turns out that CONFIG_FIQ is not enabled
by imx_v6_v7_defconfig in any way, while it's enabled for
imx_v4_v5_defconfig because there are a couple of imx_v4_v5 audio
drivers selecting the symbol.

sound/soc/fsl/Kconfig:

config SND_SOC_IMX_PCM_FIQ
        tristate
        select FIQ
        select SND_SOC_IMX_PCM