Patchwork Include <net/ip6_checksum.h> for csum_ipv6_magic

login
register
mail settings
Submitter Kevin Locke
Date July 3, 2012, 6:33 p.m.
Message ID <20120703183345.GA14043@kevinzilla>
Download mbox | patch
Permalink /patch/168850/
State Not Applicable
Headers show

Comments

Kevin Locke - July 3, 2012, 6:33 p.m.
xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
<net/ip6_checksum.h>, which is not implicitly included from other
headers on PPC causing build failures due to this function being
undefined.  So, include this header explicitly.

Note:  Same cause as <http://bugzilla.netfilter.org/show_bug.cgi?id=307>.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
---
 extensions/xt_ECHO.c |    1 +
 1 file changed, 1 insertion(+)
Jan Engelhardt - July 3, 2012, 8:54 p.m.
On Tuesday 2012-07-03 20:33, Kevin Locke wrote:

>xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
><net/ip6_checksum.h>, which is not implicitly included from other
>headers on PPC causing build failures due to this function being
>undefined.  So, include this header explicitly.

Fixed.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Locke - July 3, 2012, 11:02 p.m.
On 07/03/2012 02:54 PM, Jan Engelhardt wrote:
> On Tuesday 2012-07-03 20:33, Kevin Locke wrote:
>> xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
>> <net/ip6_checksum.h>, which is not implicitly included from other
>> headers on PPC causing build failures due to this function being
>> undefined.  So, include this header explicitly.
>
> Fixed.

Great.  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/extensions/xt_ECHO.c b/extensions/xt_ECHO.c
index efbceff..057d81a 100644
--- a/extensions/xt_ECHO.c
+++ b/extensions/xt_ECHO.c
@@ -18,6 +18,7 @@ 
 #	include <linux/netfilter_bridge.h>
 #endif
 #include <net/ip.h>
+#include <net/ip6_checksum.h>
 #include <net/ip6_route.h>
 #include <net/route.h>
 #include "compat_xtables.h"