From patchwork Tue Jul 3 10:12:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 168781 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B17FC2C00EC for ; Tue, 3 Jul 2012 20:12:52 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341915173; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=F2xKQnwttUsf2q1sZy1lV1c0r5M=; b=TO5aTf38WTN6du6 3LZ5inH5HgIZSQg8adR5G+sNjhQvjZHcs2GSeN1YEkaR5LDjmFUmexYAPAtK4kxl IPQcXdlEZ7Sd1P+mzXJ+8vbaUAfjLmNvmjJDb6yfd3JFO2PcxvckF6QUaBrnnsfU hY1PTmxAbrbzmOAurSiImsuv3k3M= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=ND3chAuU+qJYOfP+PTdNoleRGMEeSFSAUkFwdnxY0RFOEO2xv2/kJYuS/CmuB7 RibviMqTdsoK1GYg3xE7nYxz5mi21VfLcibZhR4ezFs0L/hfQdeN3SwjV7altGzO 2R8vZRQNZkmN+PMpJa8UmZHBz7lAn0eakFRfBd7s+Ze1k=; Received: (qmail 25477 invoked by alias); 3 Jul 2012 10:12:47 -0000 Received: (qmail 25467 invoked by uid 22791); 3 Jul 2012 10:12:46 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jul 2012 10:12:33 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id EE00DA5AD0; Tue, 3 Jul 2012 12:12:31 +0200 (CEST) Date: Tue, 3 Jul 2012 12:12:31 +0200 (CEST) From: Richard Guenther To: Nenad Vukicevic Cc: gcc-patches@gcc.gnu.org, tobias@grosser.es, sebpop@gmail.com, Michael Matz , Diego Novillo Subject: Re: [PATCH] Move Graphite from using PPL over to ISL In-Reply-To: Message-ID: References: <4FF1E7AD.2090005@intrepid.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Tue, 3 Jul 2012, Richard Guenther wrote: > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > > > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > > > > > On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > > > > > > > > > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > > > > > This merges from the graphite branch the move of PPL to ISL, > > > > > > and completes it where it was lacking - thanks to Micha. > > > > > > It leaves unmerged the addition of a pluto-like ISL optimizer > > > > > > as well as a bugfix for stride > 1 which did not come with > > > > > > a testcase. > > > > > > > > > > > > With this patch (ontop of the one requiring ClooG 0.17.0) > > > > > > we will require ISL 0.10 for enabling Graphite. > > > > > > > > > > > > I've bootstrapped and built various combinations with in-tree > > > > > > and out-of-tree cloog and ISL, so I'm pretty confident that > > > > > > this works. > > > > > > > > > > > > With out-of-tree ClooG and ISL a slightly older patch ontop of its > > > > > > prerequesite passed bootstrap and testing on x86_64-unknown-linux-gnu. > > > > > > > > > > > > Currently re-bootstrapping and testing on x86_64-unknown-linux-gnu. > > > > > > > > > > > > Ok for trunk? > > > > > > > > > > After trying to build from the trunk I got this error on x86_64 platform: > > > > > > > > > > make[3]: Entering directory `/eng/upc/dev/nenad/bart/bld-trunk/cloog/test' > > > > > CC generate_test.o > > > > > cd ..; make libcloog-isl.la > > > > > make[4]: Entering directory `/eng/upc/dev/nenad/bart/bld-trunk/cloog' > > > > > CC libcloog_isl_la-domain.lo > > > > > In file included from > > > > > ../../gcc-trunk/cloog/include/cloog/isl/constraintset.h:4:0, > > > > > from ../../gcc-trunk/cloog/include/cloog/isl/cloog.h:9, > > > > > from ../../gcc-trunk/cloog/source/isl/domain.c:6: > > > > > ../../gcc-trunk/cloog/include/cloog/isl/backend.h:4:28: fatal error: > > > > > > Looking again this is from the cloog build. If I repeat your tests > > > (I suppose I didn't check non-bootstrap in-tree builds) it works just > > > fine for me. The cloog/config.log should contain something like > > > > > > configure:11964: checking which isl to use > > > configure:11966: result: system > > > > > > and all gcc invocations in the configury should have include paths > > > set up to have the built isl/include first, then the source isl/include: > > > > > > configure:12073: gcc -c -g -O2 -I/abuild/rguenther/obj/./isl/include > > > -I/space/rguenther/src/svn/trunk/isl/include conftest.c >&5 > > > > > > Did you really unpack isl into the source tree as well? > > > > > > Ah, I see what might happen - if you forget to have isl inside the > > > tree we disable graphite but cloog still gets built, but will fail. > > > I'll see to fix that. > > > > Fixed with the following. I'll test it with some combinations of > > valid/invalid cloog/isl versions before installing. > > Hum. Ok, I installed the following, but in-tree builds seem to no > longer work for some reason. CPPFLAGS get dropped in some way, > even as they are present properly ... The following fixes that. Tested with various combinations of in-tree/out-of-tree cloog/isl. Installed. Richard. 2012-06-03 Richard Guenther * Makfile.def (isl): Remove not necessary extra_exports and extra_make_flags. (cloog): Use $$CPPFLAGS instead of ${CPPFLAGS}. * Makefile.in: Regenerated. Index: Makefile.def =================================================================== --- Makefile.def (revision 189209) +++ Makefile.def (working copy) @@ -63,13 +63,11 @@ host_modules= { module= mpc; lib_path=.l no_install= true; }; host_modules= { module= isl; lib_path=.libs; bootstrap=true; extra_configure_flags='--disable-shared --with-gmp-library=$$r/$(HOST_SUBDIR)/gmp/.libs --with-gmp-include=$$r/$(HOST_SUBDIR)/gmp --with-bits=gmp'; - extra_exports='CPPFLAGS="${CPPFLAGS}"; export CPPFLAGS; LDFLAGS="$$LDFLAGS"; export LDFLAGS; '; - extra_make_flags='CPPFLAGS="${CPPFLAGS}" LDFLAGS="$$LDFLAGS"'; no_install= true; }; host_modules= { module= cloog; lib_path=.libs; bootstrap=true; extra_configure_flags='--disable-shared --with-gmp-library=$$r/$(HOST_SUBDIR)/gmp/.libs --with-gmp-include=$$r/$(HOST_SUBDIR)/gmp --with-bits=gmp --with-isl=system'; - extra_exports='CPPFLAGS="-I$$r/$(HOST_SUBDIR)/isl/include -I$$s/isl/include ${CPPFLAGS}"; export CPPFLAGS; LDFLAGS="-L$$r/$(HOST_SUBDIR)/isl/.libs $$LDFLAGS"; export LDFLAGS; '; - extra_make_flags='CPPFLAGS="${CPPFLAGS}" LDFLAGS="$$LDFLAGS" V=1'; + extra_exports='CPPFLAGS="-I$$r/$(HOST_SUBDIR)/isl/include -I$$s/isl/include $$CPPFLAGS"; export CPPFLAGS; LDFLAGS="-L$$r/$(HOST_SUBDIR)/isl/.libs $$LDFLAGS"; export LDFLAGS; '; + extra_make_flags='CPPFLAGS="$$CPPFLAGS" LDFLAGS="$$LDFLAGS" V=1'; no_install= true; }; host_modules= { module= libelf; lib_path=.libs; bootstrap=true; extra_configure_flags='--disable-shared';