Patchwork [2/2] mtd: gpmi: update the bitflip_threshold

login
register
mail settings
Submitter Huang Shijie
Date July 3, 2012, 8:24 a.m.
Message ID <1341303873-23040-2-git-send-email-b32955@freescale.com>
Download mbox | patch
Permalink /patch/168734/
State New
Headers show

Comments

Huang Shijie - July 3, 2012, 8:24 a.m.
The origin code misses to update the bitflip_threshold when
we have already get the right ecc_strength.

The patch fixes it.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
David Woodhouse - July 16, 2012, 8:49 p.m.
On Tue, 2012-07-03 at 16:24 +0800, Huang Shijie wrote:
> The origin code misses to update the bitflip_threshold when
> we have already get the right ecc_strength.
> 
> The patch fixes it.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com> 

Should we be pushing this for 3.5?
Huang Shijie - July 17, 2012, 3:28 a.m.
On Tue, Jul 17, 2012 at 4:49 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> On Tue, 2012-07-03 at 16:24 +0800, Huang Shijie wrote:
>> The origin code misses to update the bitflip_threshold when
>> we have already get the right ecc_strength.
>>
>> The patch fixes it.
>>
>> Signed-off-by: Huang Shijie <b32955@freescale.com>
>
> Should we be pushing this for 3.5?
>
I think it's not needed to push this patch for 3.5.

It's okay to merge it in 3.6.


thanks
Huang Shijie

> --
> dwmw2
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Patch

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index a1bf31f..ed9571b 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1501,6 +1501,7 @@  static int gpmi_pre_bbt_scan(struct gpmi_nand_data  *this)
 	/* Adjust the ECC strength according to the chip. */
 	this->nand.ecc.strength = this->bch_geometry.ecc_strength;
 	this->mtd.ecc_strength = this->bch_geometry.ecc_strength;
+	this->mtd.bitflip_threshold = this->bch_geometry.ecc_strength;
 
 	/* NAND boot init, depends on the gpmi_set_geometry(). */
 	return nand_boot_init(this);