From patchwork Tue Jul 3 08:28:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 168731 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 19D762C00CC for ; Tue, 3 Jul 2012 18:28:54 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341908935; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=jADYqHv+fkq9UoivLDbwSE5f7Lo=; b=ST3E5JxD/AseBKY KUMPpZ+tHrep1xwky/eX6Hy1oTuctUJQV6B4Og3YM54Zt5014J585b7hS2srttdg ooPXPItOjvrH26vyFVPZIf6Un/6zlFMF+vZdJr1TcBmJpxDdBkv1alnbCu/f/waO QdF+5Y8bOde5bEk+0BPRdc/9u3dQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=xSwvElzcDIhSc22vrIzjSEGqrKPBVFT2acKovfIXZ4ykpGjD75XdZM9jx8In9e ngmx8mieWSrc92QqfjwyvZhFBTTJkHYqYNUVsv608JBvNCzg5KJAPLKKd3L+UpLA O/6r4sqGujBWC18ojMbOUDj6tBLd+LYqtx5MLHFxSTjxI=; Received: (qmail 31301 invoked by alias); 3 Jul 2012 08:28:21 -0000 Received: (qmail 31213 invoked by uid 22791); 3 Jul 2012 08:28:17 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jul 2012 08:28:04 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id AF4B489994; Tue, 3 Jul 2012 10:28:02 +0200 (CEST) Date: Tue, 3 Jul 2012 10:28:01 +0200 (CEST) From: Richard Guenther To: Nenad Vukicevic Cc: gcc-patches@gcc.gnu.org, tobias@grosser.es, sebpop@gmail.com, Michael Matz , Diego Novillo Subject: Re: [PATCH] Move Graphite from using PPL over to ISL In-Reply-To: <4FF1E7AD.2090005@intrepid.com> Message-ID: References: <4FF1E7AD.2090005@intrepid.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > This merges from the graphite branch the move of PPL to ISL, > > and completes it where it was lacking - thanks to Micha. > > It leaves unmerged the addition of a pluto-like ISL optimizer > > as well as a bugfix for stride > 1 which did not come with > > a testcase. > > > > With this patch (ontop of the one requiring ClooG 0.17.0) > > we will require ISL 0.10 for enabling Graphite. > > > > I've bootstrapped and built various combinations with in-tree > > and out-of-tree cloog and ISL, so I'm pretty confident that > > this works. > > > > With out-of-tree ClooG and ISL a slightly older patch ontop of its > > prerequesite passed bootstrap and testing on x86_64-unknown-linux-gnu. > > > > Currently re-bootstrapping and testing on x86_64-unknown-linux-gnu. > > > > Ok for trunk? > > After trying to build from the trunk I got this error on x86_64 platform: > > make[3]: Entering directory `/eng/upc/dev/nenad/bart/bld-trunk/cloog/test' > CC generate_test.o > cd ..; make libcloog-isl.la > make[4]: Entering directory `/eng/upc/dev/nenad/bart/bld-trunk/cloog' > CC libcloog_isl_la-domain.lo > In file included from > ../../gcc-trunk/cloog/include/cloog/isl/constraintset.h:4:0, > from ../../gcc-trunk/cloog/include/cloog/isl/cloog.h:9, > from ../../gcc-trunk/cloog/source/isl/domain.c:6: > ../../gcc-trunk/cloog/include/cloog/isl/backend.h:4:28: fatal error: ^^^ This means that cloog was not able to build against ISL 0.10. You should see in its configury that it uses the ISL version installed on the system (and picks up the one just built from the drop-in in the source tree). That is, cloog is configured via host_modules= { module= cloog; lib_path=.libs; bootstrap=true; extra_configure_flags='--disable-shared --with-gmp-library=$$r/$(HOST_SUBDIR)/gmp/.libs --with-gmp-include=$$r/$(HOST_SUBDIR)/gmp --with-bits=gmp --with-isl=system'; extra_exports='CPPFLAGS="-I$$r/$(HOST_SUBDIR)/isl/include -I$$s/isl/include ${CPPFLAGS}"; export CPPFLAGS; LDFLAGS="-L$$r/$(HOST_SUBDIR)/isl/.libs $$LDFLAGS"; export LDFLAGS; '; extra_make_flags='CPPFLAGS="${CPPFLAGS}" LDFLAGS="$$LDFLAGS"'; no_install= true; }; thus using --with-isl=system, via CPPFLAGS it should be able to pick up the just built ISL. You need to debug why that is not working. I suppose for installed cloog / ISL we could strengthen the configure check or re-order the includes so that the ISL include dir comes before the cloog one (if you happen to build against two different ISL versions). Thus, $(OUTPUT_OPTION) but the question is whether this will hide real issues that will pop up when cloog is built against a different ISL version than 0.10 (for example against the version that is included within the cloog tarball). So - can you double-check what happens? I did test both in-tree and out-of-tree builds, with wrong versions and correct versions. Thanks, Richard. Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in (revision 189158) +++ gcc/Makefile.in (working copy) @@ -1057,7 +1057,7 @@ BUILD_ERRORS = build/errors.o INCLUDES = -I. -I$(@D) -I$(srcdir) -I$(srcdir)/$(@D) \ -I$(srcdir)/../include @INCINTL@ \ $(CPPINC) $(GMPINC) $(DECNUMINC) \ - $(CLOOGINC) $(ISLINC) + $(ISLINC) $(CLOOGINC) .c.o: $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $<