Patchwork Add /var/www to device table

login
register
mail settings
Submitter Romain Izard
Date July 2, 2012, 8:33 a.m.
Message ID <jsrmck$gt1$1@dough.gmane.org>
Download mbox | patch
Permalink /patch/168721/
State Superseded
Headers show

Comments

Romain Izard - July 2, 2012, 8:33 a.m.
On 2012-06-25, spdawson@gmail.com <spdawson@gmail.com> wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> The /var/www directory is listed in /etc/passwd in the skeleton target
> filesystem as the home directory of the www-data user (uid 33).
>
> In the final target filesystem, /var/www should be owned by www-data. This
> is important for the lighttpd package, for example.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>

Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable,
instead of modifying the common device table ? This makes the
relationship more evident.

See the following example:
---
Thomas Petazzoni - July 3, 2012, 8:03 a.m.
Le Mon, 2 Jul 2012 08:33:24 +0000 (UTC),
Romain Izard <romain.izard.pro@gmail.com> a écrit :

> Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable,
> instead of modifying the common device table ? This makes the
> relationship more evident.

I think the point was that /var/www would not only be used by lighttpd,
but also by other web servers, and packages installing Javascript
stuff, etc.

Thomas

Patch

diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
index b8aa310..34f59b2 100644
--- a/package/lighttpd/lighttpd.mk
+++ b/package/lighttpd/lighttpd.mk
@@ -62,4 +62,9 @@  define LIGHTTPD_UNINSTALL_TARGET_CMDS
 	rm -rf $(TARGET_DIR)/usr/lib/lighttpd
 endef
 
+#<name>		<type>	<mode>	<uid>	<gid>	<major>	<minor>	<start>	<inc>	<count>
+define LIGHTTPD_PERMISSIONS
+var/www		d	755	33	33	-	-	-	-	-
+endef
+
 $(eval $(call AUTOTARGETS))