Patchwork [2/2] ARM: mxs: defconfig: Enable CONFIG_COMMON_CLK_DEBUG

login
register
mail settings
Submitter Fabio Estevam
Date July 2, 2012, 8:35 p.m.
Message ID <1341261351-7924-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/168636/
State New
Headers show

Comments

Fabio Estevam - July 2, 2012, 8:35 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

With the common clock framework in place, it is useful to enable
CONFIG_COMMON_CLK_DEBUG option, in order to easily inspect the clock tree.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/configs/mxs_defconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Shawn Guo - July 5, 2012, 12:55 a.m.
On Mon, Jul 02, 2012 at 05:35:51PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> With the common clock framework in place, it is useful to enable
> CONFIG_COMMON_CLK_DEBUG option, in order to easily inspect the clock tree.
> 

I'm ambiguous on this.  It does look useful, but on the other hand,
I'm wondering why it hasn't been enabled by framework by default.

Sascha, what's your take on this?

Regards,
Shawn

> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/configs/mxs_defconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
> index 5406c23..caa9ae1 100644
> --- a/arch/arm/configs/mxs_defconfig
> +++ b/arch/arm/configs/mxs_defconfig
> @@ -111,6 +111,7 @@ CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_DS1307=m
>  CONFIG_DMADEVICES=y
>  CONFIG_MXS_DMA=y
> +CONFIG_COMMON_CLK_DEBUG=y
>  CONFIG_EXT3_FS=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_FSCACHE=m
> -- 
> 1.7.1
>
Sascha Hauer - July 5, 2012, 6:25 a.m.
On Thu, Jul 05, 2012 at 08:55:06AM +0800, Shawn Guo wrote:
> On Mon, Jul 02, 2012 at 05:35:51PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > With the common clock framework in place, it is useful to enable
> > CONFIG_COMMON_CLK_DEBUG option, in order to easily inspect the clock tree.
> > 
> 
> I'm ambiguous on this.  It does look useful, but on the other hand,
> I'm wondering why it hasn't been enabled by framework by default.
> 
> Sascha, what's your take on this?

I also like to have debugfs support enabled in the defconfigs. I don't
know if it's desirable to enable this unconditionally when
CONFIG_DEBUGFS is enabled because I think the clk debugfs support can
have some bad influence on performance.

I think Fabios patches are fine for nor. If we decide to enable clk
debugfs support later unconditionally than all we have is two unused
lines in the defconfigs.

Sascha
Shawn Guo - July 5, 2012, 6:37 a.m.
On Thu, Jul 05, 2012 at 08:25:40AM +0200, Sascha Hauer wrote:
> I also like to have debugfs support enabled in the defconfigs. I don't
> know if it's desirable to enable this unconditionally when
> CONFIG_DEBUGFS is enabled because I think the clk debugfs support can
> have some bad influence on performance.
> 
> I think Fabios patches are fine for nor. If we decide to enable clk
> debugfs support later unconditionally than all we have is two unused
> lines in the defconfigs.
> 
Ok, I will queue both patches then.
Sascha Hauer - July 5, 2012, 7:06 a.m.
On Thu, Jul 05, 2012 at 02:37:51PM +0800, Shawn Guo wrote:
> On Thu, Jul 05, 2012 at 08:25:40AM +0200, Sascha Hauer wrote:
> > I also like to have debugfs support enabled in the defconfigs. I don't
> > know if it's desirable to enable this unconditionally when
> > CONFIG_DEBUGFS is enabled because I think the clk debugfs support can
> > have some bad influence on performance.
> > 
> > I think Fabios patches are fine for nor. If we decide to enable clk
> > debugfs support later unconditionally than all we have is two unused
> > lines in the defconfigs.
> > 
> Ok, I will queue both patches then.

Could you skip the imx patch? I also have some patches for the defconfig
from Fabio and I'd like to squash them together since the imx defconfig
could use a general update.

Sascha
Shawn Guo - July 5, 2012, 7:33 a.m.
On 5 July 2012 15:06, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Could you skip the imx patch? I also have some patches for the defconfig
> from Fabio and I'd like to squash them together since the imx defconfig
> could use a general update.
>
Sure.

Regards,
Shawn

Patch

diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index 5406c23..caa9ae1 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -111,6 +111,7 @@  CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_DS1307=m
 CONFIG_DMADEVICES=y
 CONFIG_MXS_DMA=y
+CONFIG_COMMON_CLK_DEBUG=y
 CONFIG_EXT3_FS=y
 # CONFIG_DNOTIFY is not set
 CONFIG_FSCACHE=m