From patchwork Mon Jul 2 18:27:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 168626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2F54C2C0097 for ; Tue, 3 Jul 2012 04:28:22 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341858502; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=f63dwgjsD+7ntwWFsBzZdQKt0HA=; b=QHDkxhIzJyugdUL A7Bo85sraeYMvgoWFCAD9g/SgTasOR3QVOCGLhfObTH7D11AsTlxLB4xSWuEEfm1 ZYX9nj0x/UR/dklbYvKzc/z3mduxPiN3/AtQ8uygbnT4clG4SSRvwHpn0h4xBQse HixPxsYmUy8kQlKQz6S0UiYinDL0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=vwJsnkI7mKdFAATlCydXApy8d1SmcOBqW5Q5Vf57g0qhadWzuc9rxwMx6QXGRk g0v6cMQn8UVFWDmQSkY4Kemm60D2iwSP8jKGCsaJxJb3jZhOz5J6FZG5ficvCaYd PFiRKgJnQEJGaHLNtAh9UjkEMkrZnFaIp3LWg7MfG8H+c=; Received: (qmail 3909 invoked by alias); 2 Jul 2012 18:28:12 -0000 Received: (qmail 3881 invoked by uid 22791); 2 Jul 2012 18:28:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jul 2012 18:27:57 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 054094D1; Mon, 2 Jul 2012 20:27:56 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1IFLKb6dGkKB; Mon, 2 Jul 2012 20:27:54 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 315444D0; Mon, 2 Jul 2012 20:27:54 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q62IRrE7002653; Mon, 2 Jul 2012 20:27:53 +0200 (MEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Paolo Bonzini , Richard Guenther Subject: [build] Fix ISL check with static libisl Date: Mon, 02 Jul 2012 20:27:53 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org After the move to CLooG 0.17.0/ISL 0.10, mainline fails to configure with a static libisl: configure:5697: checking for version 0.10 of ISL configure:5722: gcc -o conftest -g -O2 -I/vol/gcc/include -I/vol/gcc/include -I/ vol/gcc/include -I/vol/gcc/include -L/vol/gcc/lib -lisl -lisl conftest.c >&5 Undefined first referenced symbol in file isl_version /var/tmp//ccKVG1Pf.o ld: fatal: symbol referencing errors. No output written to conftest In the static case, -lisl needs to be added after conftest.c, not before. The following patch does just that by moving -lisl to LIBS. It allowed a i386-pc-solaris2.10 bootstrap to finish without regressions. Ok for mainline? Rainer 2012-07-02 Rainer Orth toplevel: * configure: Regenerate. config: * isl.m4 (ISL_CHECK_VERSION): Add -lisl to LIBS, not LDFLAGS. # HG changeset patch # Parent 0bb3dc9cd98a3bff227f02a830c49dece30d335b Fix ISL check with static libisl diff --git a/config/isl.m4 b/config/isl.m4 --- a/config/isl.m4 +++ b/config/isl.m4 @@ -120,9 +120,11 @@ AC_DEFUN([ISL_CHECK_VERSION], if test "${ENABLE_ISL_CHECK}" = yes ; then _isl_saved_CFLAGS=$CFLAGS _isl_saved_LDFLAGS=$LDFLAGS + _isl_saved_LIBS=$LIBS CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}" - LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs} -lisl" + LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}" + LIBS="${_isl_saved_LIBS} -lisl" echo $CFLAGS AC_CACHE_CHECK([for version $1.$2 of ISL], @@ -133,6 +135,7 @@ AC_DEFUN([ISL_CHECK_VERSION], CFLAGS=$_isl_saved_CFLAGS LDFLAGS=$_isl_saved_LDFLAGS + LIBS=$_isl_saved_LIBS fi ] )