Patchwork [build] Fix ISL check with static libisl

login
register
mail settings
Submitter Rainer Orth
Date July 2, 2012, 6:27 p.m.
Message ID <yddvci6ggra.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/168626/
State New
Headers show

Comments

Rainer Orth - July 2, 2012, 6:27 p.m.
After the move to CLooG 0.17.0/ISL 0.10, mainline fails to configure
with a static libisl:

configure:5697: checking for version 0.10 of ISL
configure:5722: gcc -o conftest -g -O2 -I/vol/gcc/include -I/vol/gcc/include -I/
vol/gcc/include -I/vol/gcc/include    -L/vol/gcc/lib -lisl -lisl conftest.c  >&5
Undefined                       first referenced
 symbol                             in file
isl_version                         /var/tmp//ccKVG1Pf.o
ld: fatal: symbol referencing errors. No output written to conftest

In the static case, -lisl needs to be added after conftest.c, not
before.  The following patch does just that by moving -lisl to LIBS.

It allowed a i386-pc-solaris2.10 bootstrap to finish without
regressions.

Ok for mainline?

	Rainer


2012-07-02  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	toplevel:
	* configure: Regenerate.

	config:
	* isl.m4 (ISL_CHECK_VERSION): Add -lisl to LIBS, not LDFLAGS.
Richard Guenther - July 3, 2012, 8:29 a.m.
On Mon, 2 Jul 2012, Rainer Orth wrote:

> After the move to CLooG 0.17.0/ISL 0.10, mainline fails to configure
> with a static libisl:
> 
> configure:5697: checking for version 0.10 of ISL
> configure:5722: gcc -o conftest -g -O2 -I/vol/gcc/include -I/vol/gcc/include -I/
> vol/gcc/include -I/vol/gcc/include    -L/vol/gcc/lib -lisl -lisl conftest.c  >&5
> Undefined                       first referenced
>  symbol                             in file
> isl_version                         /var/tmp//ccKVG1Pf.o
> ld: fatal: symbol referencing errors. No output written to conftest
> 
> In the static case, -lisl needs to be added after conftest.c, not
> before.  The following patch does just that by moving -lisl to LIBS.
> 
> It allowed a i386-pc-solaris2.10 bootstrap to finish without
> regressions.
> 
> Ok for mainline?

Yes.

Thanks,
Richard.

> 	Rainer
> 
> 
> 2012-07-02  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	toplevel:
> 	* configure: Regenerate.
> 
> 	config:
> 	* isl.m4 (ISL_CHECK_VERSION): Add -lisl to LIBS, not LDFLAGS.
> 
>

Patch

# HG changeset patch
# Parent 0bb3dc9cd98a3bff227f02a830c49dece30d335b
Fix ISL check with static libisl

diff --git a/config/isl.m4 b/config/isl.m4
--- a/config/isl.m4
+++ b/config/isl.m4
@@ -120,9 +120,11 @@  AC_DEFUN([ISL_CHECK_VERSION],
   if test "${ENABLE_ISL_CHECK}" = yes ; then
     _isl_saved_CFLAGS=$CFLAGS
     _isl_saved_LDFLAGS=$LDFLAGS
+    _isl_saved_LIBS=$LIBS
 
     CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
-    LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs} -lisl"
+    LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
+    LIBS="${_isl_saved_LIBS} -lisl"
     echo $CFLAGS
 
     AC_CACHE_CHECK([for version $1.$2 of ISL],
@@ -133,6 +135,7 @@  AC_DEFUN([ISL_CHECK_VERSION],
 
     CFLAGS=$_isl_saved_CFLAGS
     LDFLAGS=$_isl_saved_LDFLAGS
+    LIBS=$_isl_saved_LIBS
   fi
 ]
 )