From patchwork Mon Jul 2 14:02:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 168598 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 97E262C009F for ; Tue, 3 Jul 2012 00:03:06 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341842587; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=VCGXPKailYID4nEnXgDhk5pWsgE=; b=OyTZrB5S//ZlOsG 5uiKO99sOcvKRl8BAZmvj7UrtFyt1y849iISJqpV3OzaElUA7x8p71bI0KCd6nAs OEqrPFk1+NmyOqDq8KfsRGnBDPpM1dS78luZL7erVfR1f6n2hKfUiUn8tZ/YaOT8 VX/WUqt5swXLFudXb42QSOb35/Dg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=QjCq1f3KLPFm/04gxEFp1IdskvujWR6ePCVzEsW6V8Mc3+pN84d6aLTqXforkk WCGinFJP2CZoQrKwZB1EXWeB4B/swt+OXErIVbvSnQ3pmY5SDZwBP8Kex1G5XS4A 0lCcbBK897hE8iQWDsLjmApaIkHCSRbWP9RLFe7dWc/qU=; Received: (qmail 31485 invoked by alias); 2 Jul 2012 14:03:02 -0000 Received: (qmail 31468 invoked by uid 22791); 2 Jul 2012 14:03:00 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jul 2012 14:02:47 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 678BEA329D; Mon, 2 Jul 2012 16:02:46 +0200 (CEST) Date: Mon, 2 Jul 2012 16:02:46 +0200 (CEST) From: Richard Guenther To: Jack Howarth Cc: Diego Novillo , gcc-patches@gcc.gnu.org, tobias@grosser.es, sebpop@gmail.com, Michael Matz Subject: Re: [PATCH] Move Graphite from using PPL over to ISL In-Reply-To: Message-ID: References: <4FEC5204.6090001@google.com> <20120702133720.GA4736@bromo.med.uc.edu> <20120702135227.GA4813@bromo.med.uc.edu> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, 2 Jul 2012, Richard Guenther wrote: > On Mon, 2 Jul 2012, Jack Howarth wrote: > > > On Mon, Jul 02, 2012 at 09:37:20AM -0400, Jack Howarth wrote: > > > On Mon, Jul 02, 2012 at 01:43:56PM +0200, Richard Guenther wrote: > > > > On Thu, 28 Jun 2012, Diego Novillo wrote: > > > > > > > > > On 12-06-27 11:06 , Richard Guenther wrote: > > > > > > > > > > > 2012-06-27 Richard Guenther > > > > > > Michael Matz > > > > > > Tobias Grosser > > > > > > Sebastian Pop > > > > > > > > > > > > config/ > > > > > > * cloog.m4: Set up to work against ISL only. > > > > > > * isl.m4: New file. > > > > > > > > > > > > * Makefile.def: Add ISL host module, remove PPL host module. > > > > > > Adjust ClooG host module to use the proper ISL. > > > > > > * Makefile.tpl: Pass ISL include flags instead of PPL ones. > > > > > > * configure.ac: Include config/isl.m4. Add ISL host library, > > > > > > remove PPL. Remove PPL configury, add ISL configury, adjust > > > > > > ClooG configury. > > > > > > * Makefile.in: Regenerated. > > > > > > * configure: Likewise. > > > > > > > > > > > > gcc/ > > > > > > * Makefile.in: Remove PPL flags in favor of ISL ones. > > > > > > (BACKENDLIBS): Remove PPL libs. > > > > > > (INCLUDES): Remove PPL includes in favor of ISL ones. > > > > > > (graphite-clast-to-gimple.o): Remove graphite-dependences.h and > > > > > > graphite-cloog-compat.h dependencies. > > > > > > (graphite-dependences.o): Likewise. > > > > > > (graphite-poly.o): Likewise. > > > > > > * configure.ac: Declare ISL vars instead of PPL ones. > > > > > > * configure: Regenerated. > > > > > > * doc/install.texi: Replace PPL requirement documentation > > > > > > with ISL one. > > > > > > * graphite-blocking.c: Remove PPL code, add ISL equivalent. > > > > > > * graphite-clast-to-gimple.c: Likewise. > > > > > > * graphite-dependences.c: Likewise. > > > > > > * graphite-interchange.c: Likewise. > > > > > > * graphite-poly.h: Likewise. > > > > > > * graphite-poly.c: Likewise. > > > > > > * graphite-sese-to-poly.c: Likewise. > > > > > > * graphite.c: Likewise. > > > > > > * graphite-scop-detection.c: Re-arrange includes. > > > > > > * graphite-cloog-util.c: Remove. > > > > > > * graphite-cloog-util.h: Likewise. > > > > > > * graphite-ppl.h: Likewise. > > > > > > * graphite-ppl.c: Likewise. > > > > > > * graphite-dependences.h: Likewise. > > > > > > > > > > > > libgomp/ > > > > > > * testsuite/libgomp.graphite/force-parallel-4.c: Adjust. > > > > > > * testsuite/libgomp.graphite/force-parallel-5.c: Likewise. > > > > > > * testsuite/libgomp.graphite/force-parallel-7.c: Likewise. > > > > > > * testsuite/libgomp.graphite/force-parallel-8.c: Likewise. > > > > > > > > > > OK. > > > > > > > > Committed. > > > > > > > > Richard. > > > > > > Richard, > > > At r189157, with isl 0.10 and cloog.org 0.17.0 installed from the infrastructure > > > directory, I am seeing a configure failure with... > > > > > > $ ../gcc-4.8-20120702/configure --prefix=/sw --prefix=/sw/lib/gcc4.8 --mandir=/sw/share/man --infodir=/sw/lib/gcc4.8/info --enable-languages=c,c++,fortran,lto,objc,obj-c++,java --with-gmp=/sw --with-libiconv-prefix=/sw --with-isl=/sw --with-cloog=/sw --with-mpc=/sw --with-system-zlib --enable-checking=yes --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib --program-suffix=-fsf-4.8 > > > > > > of... > > > > > > configure:5697: checking for version 0.10 of ISL > > > configure:5725: gcc -o conftest -g -O2 -I/sw/include -I/sw/include -I/sw/include -L/sw/lib -lisl -lisl conftest.c >&5 > > > conftest.c:15:11: error: expected ';' at end of declaration > > > int main() > > > ^ > > > ; > > > 1 error generated. > > > configure:5725: $? = 1 > > > configure: program exited with status 1 > > > configure: failed program was: > > > | /* confdefs.h */ > > > | #define PACKAGE_NAME "" > > > | #define PACKAGE_TARNAME "" > > > | #define PACKAGE_VERSION "" > > > | #define PACKAGE_STRING "" > > > | #define PACKAGE_BUGREPORT "" > > > | #define PACKAGE_URL "" > > > | #define LT_OBJDIR ".libs/" > > > | /* end confdefs.h. */ > > > | #include > > > | #include > > > | int > > > | main () > > > | { > > > | int main() > > > | { > > > | if (strncmp (isl_version (), "isl-0.10", strlen ("isl-0.10")) != 0) > > > | return 1; > > > | return 0; > > > | } > > > | ; > > > | return 0; > > > | } > > > configure:5735: result: no > > > configure:5769: error: Unable to find a usable ISL. See config.log for details. > > > > Richard, > > Regenerating the top-level configure with 'autoconf -I. -I./config' at r189157 doesn't resolve the issue. > > Yeah, I see the issue ;) Still my host compilers happily accept > int main() { int main () {} } and do not error: > > configure:5697: checking for version 0.10 of ISL > configure:5725: gcc -o conftest -g -lisl -lisl conftest.c >&5 > configure:5725: $? = 0 > configure:5725: ./conftest > configure:5725: $? = 0 > configure:5735: result: yes > > I'll test a fix. Like so. Richard. 2012-07-02 Richard Guenther config/ * isl.m4 (_ISL_CHECK_CT_PROG): Omit main function header/footer. Fix version test. * configure: Regenerated. diff --git a/config/isl.m4 b/config/isl.m4 index 0ddeddb..c541158 100644 --- a/config/isl.m4 +++ b/config/isl.m4 @@ -107,12 +107,9 @@ AC_DEFUN([ISL_REQUESTED], m4_define([_ISL_CHECK_CT_PROG],[AC_LANG_PROGRAM( [#include #include ], - [int main() - { - if (strncmp (isl_version (), "isl-0.10", strlen ("isl-$1.$2")) != 0) - return 1; - return 0; - }])]) + [if (strncmp (isl_version (), "isl-$1.$2", strlen ("isl-$1.$2")) != 0) + return 1; + ])]) # ISL_CHECK_VERSION ISL_CHECK_VERSION (MAJOR, MINOR) # ---------------------------------------------------------------- diff --git a/configure b/configure index b157a72..0dd80ca 100755 --- a/configure +++ b/configure @@ -5712,12 +5712,9 @@ else int main () { -int main() - { - if (strncmp (isl_version (), "isl-0.10", strlen ("isl-0.10")) != 0) - return 1; - return 0; - } +if (strncmp (isl_version (), "isl-0.10", strlen ("isl-0.10")) != 0) + return 1; + ; return 0; }