Patchwork [resend] Globally disable PKG_CONFIG_PATH

login
register
mail settings
Submitter Arnout Vandecappelle
Date June 30, 2012, 8:29 p.m.
Message ID <1341088162-16689-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/168330/
State Accepted
Headers show

Comments

Arnout Vandecappelle - June 30, 2012, 8:29 p.m.
If PKG_CONFIG_PATH is set in the environment, it allows pkg-config to
look for libraries outside of the buildroot tree.  This is a problem
both for host and target builds.  To avoid it, globally set an empty
PKG_CONFIG_PATH in the environment.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 Makefile |    3 +++
 1 file changed, 3 insertions(+)
Peter Korsgaard - June 30, 2012, 10:27 p.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> If PKG_CONFIG_PATH is set in the environment, it allows pkg-config to
 Arnout> look for libraries outside of the buildroot tree.  This is a problem
 Arnout> both for host and target builds.  To avoid it, globally set an empty
 Arnout> PKG_CONFIG_PATH in the environment.

Committed, thanks.

Patch

diff --git a/Makefile b/Makefile
index 7a66897..bcbe9fc 100644
--- a/Makefile
+++ b/Makefile
@@ -165,6 +165,9 @@  HOSTNM:=$(shell which $(HOSTNM) || type -p $(HOSTNM) || echo nm)
 export HOSTAR HOSTAS HOSTCC HOSTCXX HOSTFC HOSTLD
 export HOSTCC_NOCCACHE HOSTCXX_NOCCACHE
 
+# Make sure pkg-config doesn't look outside the buildroot tree
+unexport PKG_CONFIG_PATH
+
 # bash prints the name of the directory on 'cd <dir>' if CDPATH is
 # set, so unset it here to not cause problems. Notice that the export
 # line doesn't affect the environment of $(shell ..) calls, so