Patchwork build: restore -version-info

login
register
mail settings
Submitter Jan Engelhardt
Date June 30, 2012, 6:47 p.m.
Message ID <1341082043-26584-2-git-send-email-jengelh@inai.de>
Download mbox | patch
Permalink /patch/168327/
State Not Applicable
Headers show

Comments

Jan Engelhardt - June 30, 2012, 6:47 p.m.
There was no noticable reason to switch to -version-number;
version-number would have also seen the use of 3:0:0, not 3:0:1.

3:0:1 only makes sense with -version-info, so put "-version-info"
back. However, since ipset-6.13 already released libipset.so.3, going
back to .so.2 might not be such a good idea, so continue using .so.3
by means of 3:0:0.

Also note that the version names in libipset.map generally are not
supposed to follow SO versions, but the program version):
IPSET_6.13 {...}.
---
 Make_global.am  |    2 +-
 lib/Makefile.am |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Jozsef Kadlecsik - June 30, 2012, 10:05 p.m.
Hi Jan,

On Sat, 30 Jun 2012, Jan Engelhardt wrote:

> There was no noticable reason to switch to -version-number;
> version-number would have also seen the use of 3:0:0, not 3:0:1.
> 
> 3:0:1 only makes sense with -version-info, so put "-version-info"
> back. However, since ipset-6.13 already released libipset.so.3, going
> back to .so.2 might not be such a good idea, so continue using .so.3
> by means of 3:0:0.
> 
> Also note that the version names in libipset.map generally are not
> supposed to follow SO versions, but the program version):
> IPSET_6.13 {...}.
> ---
>  Make_global.am  |    2 +-
>  lib/Makefile.am |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Make_global.am b/Make_global.am
> index 4a8f61a..446c4de 100644
> --- a/Make_global.am
> +++ b/Make_global.am
> @@ -69,7 +69,7 @@
>  # interface. 
>  
>  #            curr:rev:age
> -LIBVERSION = 3:0:1
> +LIBVERSION = 3:0:0

The new library release is backward compatible with the previous one, so 
age must be incremented. That's why I set LIBVERSION to 3:0:1 from 2:1:0. 
Or do I miss something from the library interface version description 
cited in Make_global.am?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt - June 30, 2012, 10:15 p.m.
On Sunday 2012-07-01 00:05, Jozsef Kadlecsik wrote:
>> 
>> diff --git a/Make_global.am b/Make_global.am
>> index 4a8f61a..446c4de 100644
>> --- a/Make_global.am
>> +++ b/Make_global.am
>> @@ -69,7 +69,7 @@
>>  # interface. 
>>  
>>  #            curr:rev:age
>> -LIBVERSION = 3:0:1
>> +LIBVERSION = 3:0:0
>
>The new library release is backward compatible with the previous one, so 
>age must be incremented. That's why I set LIBVERSION to 3:0:1 from 2:1:0. 

Correct -- if you had stayed with "-version-info", which you did not.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik - June 30, 2012, 10:31 p.m.
On Sun, 1 Jul 2012, Jan Engelhardt wrote:

> On Sunday 2012-07-01 00:05, Jozsef Kadlecsik wrote:
> >> 
> >> diff --git a/Make_global.am b/Make_global.am
> >> index 4a8f61a..446c4de 100644
> >> --- a/Make_global.am
> >> +++ b/Make_global.am
> >> @@ -69,7 +69,7 @@
> >>  # interface. 
> >>  
> >>  #            curr:rev:age
> >> -LIBVERSION = 3:0:1
> >> +LIBVERSION = 3:0:0
> >
> >The new library release is backward compatible with the previous one, so 
> >age must be incremented. That's why I set LIBVERSION to 3:0:1 from 2:1:0. 
> 
> Correct -- if you had stayed with "-version-info", which you did not.

So if it's reverted back (second part of your patch), the the first part 
is to be skipped.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt - June 30, 2012, 10:50 p.m.
On Sunday 2012-07-01 00:31, Jozsef Kadlecsik wrote:

>On Sun, 1 Jul 2012, Jan Engelhardt wrote:
>
>> On Sunday 2012-07-01 00:05, Jozsef Kadlecsik wrote:
>> >> 
>> >> diff --git a/Make_global.am b/Make_global.am
>> >> index 4a8f61a..446c4de 100644
>> >> --- a/Make_global.am
>> >> +++ b/Make_global.am
>> >> @@ -69,7 +69,7 @@
>> >>  # interface. 
>> >>  
>> >>  #            curr:rev:age
>> >> -LIBVERSION = 3:0:1
>> >> +LIBVERSION = 3:0:0
>> >
>> >The new library release is backward compatible with the previous one, so 
>> >age must be incremented. That's why I set LIBVERSION to 3:0:1 from 2:1:0. 
>> 
>> Correct -- if you had stayed with "-version-info", which you did not.
>
>So if it's reverted back (second part of your patch), the the first part 
>is to be skipped.

Since you already have made a release (ipset-6.13) emitting an .so.3
file, I don't think you should go back to .so.2. Hence I am using 3:0:0.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik - July 1, 2012, 12:11 p.m.
On Sun, 1 Jul 2012, Jan Engelhardt wrote:

> On Sunday 2012-07-01 00:31, Jozsef Kadlecsik wrote:
> 
> >On Sun, 1 Jul 2012, Jan Engelhardt wrote:
> >
> >> On Sunday 2012-07-01 00:05, Jozsef Kadlecsik wrote:
> >> >> 
> >> >> diff --git a/Make_global.am b/Make_global.am
> >> >> index 4a8f61a..446c4de 100644
> >> >> --- a/Make_global.am
> >> >> +++ b/Make_global.am
> >> >> @@ -69,7 +69,7 @@
> >> >>  # interface. 
> >> >>  
> >> >>  #            curr:rev:age
> >> >> -LIBVERSION = 3:0:1
> >> >> +LIBVERSION = 3:0:0
> >> >
> >> >The new library release is backward compatible with the previous one, so 
> >> >age must be incremented. That's why I set LIBVERSION to 3:0:1 from 2:1:0. 
> >> 
> >> Correct -- if you had stayed with "-version-info", which you did not.
> >
> >So if it's reverted back (second part of your patch), the the first part 
> >is to be skipped.
> 
> Since you already have made a release (ipset-6.13) emitting an .so.3
> file, I don't think you should go back to .so.2. Hence I am using 3:0:0.

What I meant is to keep LIBVERSION = 3:0:1, because that's right from 
backward compatibility view, and restore back -version-info.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt - July 1, 2012, 4:03 p.m.
On Sunday 2012-07-01 14:11, Jozsef Kadlecsik wrote:
>> >> 
>> >> Correct -- if you had stayed with "-version-info", which you did not.
>> >
>> >So if it's reverted back (second part of your patch), the the first part 
>> >is to be skipped.
>> 
>> Since you already have made a release (ipset-6.13) emitting an .so.3
>> file, I don't think you should go back to .so.2. Hence I am using 3:0:0.
>
>What I meant is to keep LIBVERSION = 3:0:1, because that's right from 
>backward compatibility view, and restore back -version-info.

What part was unclear?

* 6.13 uses -version-number 3:0:1
* that causes production of .so.3
* it's set in stone
* next incompatible change requires use of .so.4

* going back to .so.2 not a good idea
* humans are prone to errors and
  would reuse .so.3 in error

* therefore the patch makes a clean restart,
  using -version-info 3:0:0, to continue using .so.3
  starting from ipset-6.13 until the next *real*
  incompatible change.

(If you care about the uninteresting third digit,
-version-info 3:1:0 would be wanted.)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik - July 1, 2012, 5:20 p.m.
On Sun, 1 Jul 2012, Jan Engelhardt wrote:

> 
> On Sunday 2012-07-01 14:11, Jozsef Kadlecsik wrote:
> >> >> 
> >> >> Correct -- if you had stayed with "-version-info", which you did not.
> >> >
> >> >So if it's reverted back (second part of your patch), the the first part 
> >> >is to be skipped.
> >> 
> >> Since you already have made a release (ipset-6.13) emitting an .so.3
> >> file, I don't think you should go back to .so.2. Hence I am using 3:0:0.
> >
> >What I meant is to keep LIBVERSION = 3:0:1, because that's right from 
> >backward compatibility view, and restore back -version-info.
> 
> What part was unclear?
> 
> * 6.13 uses -version-number 3:0:1
> * that causes production of .so.3
> * it's set in stone
> * next incompatible change requires use of .so.4

Yes ,right.

[...] 
> * therefore the patch makes a clean restart,
>   using -version-info 3:0:0, to continue using .so.3
>   starting from ipset-6.13 until the next *real*
>   incompatible change.

What is still unclear for me, why a clean restart is required. Looking 
into "libtool", as I see, "-version-number 3:0:1" and "-version-info 
3:0:1" produces the same result. Why should the support of the previous 
interface be excluded?

> (If you care about the uninteresting third digit,
> -version-info 3:1:0 would be wanted.)

Now, you have confused me completely. -version-info 3:1:0 is converted 
directly into current, revision and age, in this order.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Make_global.am b/Make_global.am
index 4a8f61a..446c4de 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -69,7 +69,7 @@ 
 # interface. 
 
 #            curr:rev:age
-LIBVERSION = 3:0:1
+LIBVERSION = 3:0:0
 
 AM_CPPFLAGS = $(kinclude_CFLAGS) $(all_includes) -I$(top_srcdir)/include \
 	-I/usr/local/include
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 392b5f9..fd853dd 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -19,7 +19,7 @@  lib_LTLIBRARIES = libipset.la
 
 include $(top_srcdir)/lib/Make_extra.am
 
-libipset_la_LDFLAGS = -Wl,--version-script=$(top_srcdir)/lib/libipset.map -version-number $(LIBVERSION)
+libipset_la_LDFLAGS = -Wl,--version-script=$(top_srcdir)/lib/libipset.map -version-info $(LIBVERSION)
 libipset_la_LIBADD  = ${libmnl_LIBS} $(IPSET_SETTYPE_STATIC_OBJECTS)
 libipset_la_SOURCES = \
 	data.c \