From patchwork Sat Jun 30 11:48:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [-next] netfilter: use kfree_skb() not kfree() X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 168296 Message-Id: <20120630114853.GA22767@elgon.mountain> To: Bart De Schuymer Cc: Pablo Neira Ayuso , Patrick McHardy , Stephen Hemminger , "David S. Miller" , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sat, 30 Jun 2012 14:48:53 +0300 From: Dan Carpenter List-Id: This was should be a kfree_skb() here to free the sk_buff pointer. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c index 1bd1732..dfbb019 100644 --- a/net/bridge/netfilter/ebt_ulog.c +++ b/net/bridge/netfilter/ebt_ulog.c @@ -156,7 +156,7 @@ static void ebt_ulog_packet(unsigned int hooknr, const struct sk_buff *skb, nlh = nlmsg_put(ub->skb, 0, ub->qlen, 0, size - NLMSG_ALIGN(sizeof(*nlh)), 0); if (!nlh) { - kfree(ub->skb); + kfree_skb(ub->skb); ub->skb = NULL; goto unlock; }